From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tezkb-0004SI-OK for qemu-devel@nongnu.org; Sat, 01 Dec 2012 21:57:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tezka-0006Bg-Hu for qemu-devel@nongnu.org; Sat, 01 Dec 2012 21:57:49 -0500 Received: from mout.web.de ([212.227.15.3]:58907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tezka-0006Bb-7I for qemu-devel@nongnu.org; Sat, 01 Dec 2012 21:57:48 -0500 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sun, 2 Dec 2012 03:57:17 +0100 Message-Id: <1354417042-8818-1-git-send-email-andreas.faerber@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , peter.crosthwaite@xilinx.com, Igor Mitsyanko , =?UTF-8?q?Andreas=20F=C3=A4rber?= , kraxel@redhat.com, Vincent Palatin , walimisdev@gmail.com Hello, Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. As requested by Gerd, this now follows up with the cleanups I had requested from Peter C. Apart from using the new-style QOM casts it also achieves some deduplification. It then goes on to implement the suggested more slim way to have different capsbase and opregbase values; the alternative would be to create a new struct SysBusEHCIInfo for declarative initialization. Given that there are only few models for now, the imperative approach allows for more flexibility such as inheritence when, e.g., an Exynos 5 model varies only slightly from Exynos 4. Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to show how this works out. Regards, Andreas Changes from Liming Wang's patchset: * Introduce abstract sysbus-ehci-usb and pci-ehci-usb types * Move class_init / instance_init to base type as far as possible * Use TYPE_* constant for instantiating exynos4210 EHCI * Added my tegra2 SysBus EHCI device to the mix Cc: Gerd Hoffmann Cc: Peter A. G. Crosthwaite Cc: Peter Maydell Cc: Igor Mitsyanko Cc: Liming Wang Cc: Vincent Palatin Andreas Färber (4): usb/ehci: Clean up SysBus and PCI EHCI split usb/ehci: Move capsbase and opregbase into SysBus EHCI class usb/ehci: Add SysBus EHCI device for Exynos4210 usb/ehci: Add Tegra2 SysBus EHCI device Liming Wang (1): exynos4210: Add EHCI support hw/exynos4210.c | 7 +++++ hw/exynos4210_gic.c | 2 +- hw/usb/hcd-ehci-pci.c | 37 ++++++++++++++++------ hw/usb/hcd-ehci-sysbus.c | 76 ++++++++++++++++++++++++++++++++++++++++++---- hw/usb/hcd-ehci.h | 2 ++ 5 Dateien geändert, 108 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-) -- 1.7.10.4