From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfKuH-0001Np-MC for qemu-devel@nongnu.org; Sun, 02 Dec 2012 20:33:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfKuF-0005e1-Sa for qemu-devel@nongnu.org; Sun, 02 Dec 2012 20:33:13 -0500 Received: from [222.73.24.84] (port=35360 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfKuF-0005dT-IJ for qemu-devel@nongnu.org; Sun, 02 Dec 2012 20:33:11 -0500 From: li guang In-Reply-To: References: <1354159971-6720-1-git-send-email-lig.fnst@cn.fujitsu.com> <1354159971-6720-2-git-send-email-lig.fnst@cn.fujitsu.com> Date: Mon, 03 Dec 2012 09:30:46 +0800 Message-ID: <1354498246.9576.5.camel@liguang.fnst.cn.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 2/3] use dr7's bit name for breakpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: imammedo@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de, ehabkost@redhat.com =E5=9C=A8 2012-11-29=E5=9B=9B=E7=9A=84 11:28 +0000=EF=BC=8CPeter Maydell=E5= =86=99=E9=81=93=EF=BC=9A > On 29 November 2012 03:32, liguang wrote: > > Signed-off-by: liguang > > --- > > target-i386/cpu.h | 2 ++ > > target-i386/helper.c | 24 +++++++++++------------- > > target-i386/misc_helper.c | 6 +++--- > > target-i386/seg_helper.c | 6 +++--- > > 4 files changed, 19 insertions(+), 19 deletions(-) > > > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > > index 7f292e6..7ecfe21 100644 > > --- a/target-i386/cpu.h > > +++ b/target-i386/cpu.h > > @@ -561,6 +561,8 @@ > > /* dr7 fields */ > > /* max breakpoints*/ > > #define MAX_BP 4 > > +/*enable local breakpoint bit 0,2,4,6*/ > > +#define BP_LOCAL 0x55 >=20 > This needs a better name, to make it clear that it's not > just a single enable bit but actually a mask of all the > local enable bits. Also needs DR7_ prefix. >=20 > You've split these changes up between patches inconsistently; > either have one patch which adds all the constants and > then patches which just use them, or have patches which > both add and use the constants, but don't mix the two. >=20 > I'd recommend that each patch should both add and use a > related set of constants, so it's self contained and > easy to review. you're right, thanks! >=20 > -- PMM >=20 --=20 regards! li guang =20 linux kernel team at FNST, china thinking with brain but heart living with heart but brain