From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfiRL-00005r-22 for qemu-devel@nongnu.org; Mon, 03 Dec 2012 21:41:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfiR8-0002Rl-K9 for qemu-devel@nongnu.org; Mon, 03 Dec 2012 21:40:54 -0500 From: David Gibson Date: Tue, 4 Dec 2012 13:42:13 +1100 Message-Id: <1354588937-27122-10-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1354588937-27122-1-git-send-email-david@gibson.dropbear.id.au> References: <1354588937-27122-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PATCH 09/13] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson The PAPR specification requires that every bus or device mediated by the IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check to enforce this, which will help catch errors in configuration earlier. Signed-off-by: David Gibson --- hw/spapr_iommu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/spapr_iommu.c b/hw/spapr_iommu.c index 02d78cc..3011b25 100644 --- a/hw/spapr_iommu.c +++ b/hw/spapr_iommu.c @@ -120,6 +120,12 @@ DMAContext *spapr_tce_new_dma_context(uint32_t liobn, size_t window_size) { sPAPRTCETable *tcet; + if (spapr_tce_find_by_liobn(liobn)) { + fprintf(stderr, "Attempted to create TCE table with duplicate" + " LIOBN 0x%x\n", liobn); + return NULL; + } + if (!window_size) { return NULL; } -- 1.7.10.4