qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com, agl@us.ibm.com
Subject: [Qemu-devel] [RFC 1/3] virtio-balloon: drop old stats code
Date: Tue,  4 Dec 2012 13:04:46 -0200	[thread overview]
Message-ID: <1354633488-24112-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1354633488-24112-1-git-send-email-lcapitulino@redhat.com>

Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it, drop it then.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hw/virtio-balloon.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index dd1a650..4398025 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -164,28 +164,6 @@ static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f)
 static void virtio_balloon_stat(void *opaque, BalloonInfo *info)
 {
     VirtIOBalloon *dev = opaque;
-
-#if 0
-    /* Disable guest-provided stats for now. For more details please check:
-     * https://bugzilla.redhat.com/show_bug.cgi?id=623903
-     *
-     * If you do enable it (which is probably not going to happen as we
-     * need a new command for it), remember that you also need to fill the
-     * appropriate members of the BalloonInfo structure so that the stats
-     * are returned to the client.
-     */
-    if (dev->vdev.guest_features & (1 << VIRTIO_BALLOON_F_STATS_VQ)) {
-        virtqueue_push(dev->svq, &dev->stats_vq_elem, dev->stats_vq_offset);
-        virtio_notify(&dev->vdev, dev->svq);
-        return;
-    }
-#endif
-
-    /* Stats are not supported.  Clear out any stale values that might
-     * have been set by a more featureful guest kernel.
-     */
-    reset_stats(dev);
-
     info->actual = ram_size - ((uint64_t) dev->actual <<
                                VIRTIO_BALLOON_PFN_SHIFT);
 }
-- 
1.8.0

  reply	other threads:[~2012-12-04 15:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 15:04 [Qemu-devel] [RFC 0/3] re-enable balloon stats Luiz Capitulino
2012-12-04 15:04 ` Luiz Capitulino [this message]
2012-12-04 15:04 ` [Qemu-devel] [RFC 2/3] virtio-balloon: " Luiz Capitulino
2012-12-06 17:03   ` mdroth
2012-12-06 17:58     ` Luiz Capitulino
2012-12-04 15:04 ` [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats Luiz Capitulino
2012-12-06 13:24   ` Daniel P. Berrange
2012-12-06 15:31     ` Luiz Capitulino
2012-12-06 16:59       ` mdroth
2012-12-07  5:30   ` Dietmar Maurer
2012-12-07 12:23     ` Luiz Capitulino
2012-12-07 15:01       ` Dietmar Maurer
2012-12-07 18:54         ` Luiz Capitulino
2012-12-08  6:26           ` Dietmar Maurer
2012-12-10 11:19             ` Luiz Capitulino
2012-12-10 12:06               ` Dietmar Maurer
2012-12-10  7:52           ` Alexandre DERUMIER

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354633488-24112-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=agl@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).