From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgLq2-0000CM-VH for qemu-devel@nongnu.org; Wed, 05 Dec 2012 15:45:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgLq1-0001FI-KM for qemu-devel@nongnu.org; Wed, 05 Dec 2012 15:45:02 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:34805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgLq1-0001A6-Dr for qemu-devel@nongnu.org; Wed, 05 Dec 2012 15:45:01 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so3380479eek.4 for ; Wed, 05 Dec 2012 12:45:01 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 5 Dec 2012 21:44:38 +0100 Message-Id: <1354740282-20679-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1354740282-20679-1-git-send-email-pbonzini@redhat.com> References: <1354740282-20679-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 07/11] qdev: add reference for the bus while it is referred to by the DeviceState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, afaerber@suse.de Now that the unparent callbacks are complete, we can correctly account more missing references. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index d7f1545..62b6c14 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -101,6 +101,7 @@ static void bus_add_child(BusState *bus, DeviceState *child) void qdev_set_parent_bus(DeviceState *dev, BusState *bus) { dev->parent_bus = bus; + object_ref(OBJECT(bus)); bus_add_child(bus, dev); } @@ -734,6 +735,8 @@ static void qdev_remove_from_bus(Object *obj) } if (dev->parent_bus) { bus_remove_child(dev->parent_bus, dev); + object_unref(OBJECT(dev->parent_bus)); + dev->parent_bus = NULL; } } -- 1.8.0.1