From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 10/13] target-i386/cpu.c: Coding style fixes
Date: Thu, 6 Dec 2012 10:06:54 +0100 [thread overview]
Message-ID: <1354784817-1340-11-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1354784817-1340-1-git-send-email-afaerber@suse.de>
From: Eduardo Habkost <ehabkost@redhat.com>
- Use spaces instead of tabs on cpu_x86_cpuid().
- Use braces on 'if' statement cpu_x86_find_by_name().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
target-i386/cpu.c | 30 ++++++++++++++++--------------
1 Datei geändert, 16 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c6c2ca0..754af68 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1215,7 +1215,7 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model)
char *s = g_strdup(cpu_model);
char *featurestr, *name = strtok(s, ",");
- /* Features to be added*/
+ /* Features to be added */
uint32_t plus_features = 0, plus_ext_features = 0;
uint32_t plus_ext2_features = 0, plus_ext3_features = 0;
uint32_t plus_kvm_features = kvm_default_features, plus_svm_features = 0;
@@ -1227,9 +1227,11 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model)
uint32_t minus_7_0_ebx_features = 0;
uint32_t numvalue;
- for (def = x86_defs; def; def = def->next)
- if (name && !strcmp(name, def->name))
+ for (def = x86_defs; def; def = def->next) {
+ if (name && !strcmp(name, def->name)) {
break;
+ }
+ }
if (kvm_enabled() && name && strcmp(name, "host") == 0) {
kvm_cpu_fill_host(x86_cpu_def);
} else if (!def) {
@@ -1835,17 +1837,17 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
}
break;
case 0x8000000A:
- if (env->cpuid_ext3_features & CPUID_EXT3_SVM) {
- *eax = 0x00000001; /* SVM Revision */
- *ebx = 0x00000010; /* nr of ASIDs */
- *ecx = 0;
- *edx = env->cpuid_svm_features; /* optional features */
- } else {
- *eax = 0;
- *ebx = 0;
- *ecx = 0;
- *edx = 0;
- }
+ if (env->cpuid_ext3_features & CPUID_EXT3_SVM) {
+ *eax = 0x00000001; /* SVM Revision */
+ *ebx = 0x00000010; /* nr of ASIDs */
+ *ecx = 0;
+ *edx = env->cpuid_svm_features; /* optional features */
+ } else {
+ *eax = 0;
+ *ebx = 0;
+ *ecx = 0;
+ *edx = 0;
+ }
break;
case 0xC0000000:
*eax = env->cpuid_xlevel2;
--
1.7.10.4
next prev parent reply other threads:[~2012-12-06 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:06 [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06 Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 01/13] user: Move *-user/qemu-types.h to main directory Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 02/13] user: Rename qemu-types.h to qemu-user-types.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 03/13] ui/vnc-palette.c: Include headers it needs Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 04/13] qapi/qmp-registry.c: " Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 05/13] qga/channel-posix.c: " Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 06/13] qlist.h: Do not include qemu-common.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 07/13] Create qemu-types.h for struct typedefs Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 08/13] sysemu.h: Include qemu-types.h instead of qemu-common.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 09/13] qdev: qdev_create(): use error_report() instead of hw_error() Andreas Färber
2012-12-06 9:06 ` Andreas Färber [this message]
2012-12-06 9:06 ` [Qemu-devel] [PATCH 11/13] target-i386: Separate feature string parsing from CPU model lookup Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 12/13] target-i386: Use define for cpuid vendor string size Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time Andreas Färber
2012-12-07 17:57 ` Eduardo Habkost
2012-12-07 18:18 ` Andreas Färber
2012-12-07 18:00 ` [Qemu-devel] [PATCH] " Eduardo Habkost
2012-12-07 18:28 ` Andreas Färber
2012-12-07 18:21 ` [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06 Andreas Färber
2012-12-10 16:57 ` Anthony Liguori
2012-12-10 17:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354784817-1340-11-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).