[Qemu-devel] [PULL 00/13] Trivial patches for 2 to 7 November

[Qemu-devel] [PULL 00/13] Trivial patches for 2 to 7 November

[Stefan Hajnoczi]

These patches were mostly submitted during the 1.3 hard freeze.  I'll catch up
with the new trivial patches next week.

The following changes since commit 80625b97b52836b944a6438e8e3e9d992e6a00b6:

  xilinx_uartlite: Accept input after rx FIFO pop (2012-12-05 09:20:36 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git trivial-patches

for you to fetch changes up to 654598c944aa31cdbea435bd468055af9c918d16:

  pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path (2012-12-07 12:34:12 +0100)

----------------------------------------------------------------
Markus Armbruster (2):
      Clean up pci_drive_hot_add()'s use of BlockInterfaceType
      pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path

Michal Privoznik (1):
      qemu-options: Fix space at EOL

Petar Jovanovic (2):
      target-mips: Fix incorrect code and test for INSV
      target-mips: Fix incorrect shift for SHILO and SHILOV

Peter Crosthwaite (2):
      sd: Send debug printfery to stderr not stdout
      arm: a9mpcore: remove un-used ptimer_iomem field

Peter Maydell (1):
      configure: Remove stray debug output

Richard Henderson (3):
      target-alpha: Remove t0, t1 from CPUAlphaState
      target-m68k: Remove t1 from CPUM68KState
      target-sparc: Remove t0, t1 from CPUSPARCState

Stefan Weil (4):
      Fix spelling (prefered -> preferred)
      Fix comments (adress -> address, layed -> laid, wierd -> weird)
      s390x: Spelling fixes (endianess -> endianness, occured -> occurred)
      Fix spelling in comments and documentation

 configure                          |  4 +---
 hw/a9mpcore.c                      |  1 -
 hw/device-hotplug.c                | 11 ++++-------
 hw/pc_sysfw.c                      |  4 +++-
 hw/pci-hotplug.c                   |  7 +++----
 hw/s390x/sclp.h                    |  4 ++--
 hw/s390x/sclpconsole.c             |  4 ++--
 hw/sd.c                            |  4 ++--
 hw/usb.h                           |  6 +++---
 net/tap-win32.c                    |  7 ++++---
 qemu-options.hx                    |  2 +-
 slirp/ip_icmp.c                    |  2 +-
 sysemu.h                           |  3 +--
 target-alpha/cpu.h                 |  7 -------
 target-m68k/cpu.h                  |  3 ---
 target-mips/dsp_helper.c           | 19 ++++++++++---------
 target-sparc/cpu.h                 |  1 -
 tcg/tcg.h                          |  4 ++--
 tests/qemu-iotests/iotests.py      |  2 +-
 tests/tcg/mips/mips32-dsp/insv.c   |  2 +-
 tests/tcg/mips/mips32-dsp/shilo.c  | 18 ++++++++++++++++++
 tests/tcg/mips/mips32-dsp/shilov.c | 20 ++++++++++++++++++++
 uri.c                              |  4 ++--
 23 files changed, 81 insertions(+), 58 deletions(-)

-- 
1.8.0.1

[Qemu-devel] [PATCH 01/13] sd: Send debug printfery to stderr not stdout

[Stefan Hajnoczi]

From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Some debug printfs for SD are coming up in stdout. Redirected them to stderr
instead.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sd.c b/hw/sd.c
index 3c34d43..607edba 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -1439,8 +1439,8 @@ send_response:
         int i;
         DPRINTF("Response:");
         for (i = 0; i < rsplen; i++)
-            printf(" %02x", response[i]);
-        printf(" state %d\n", sd->state);
+            fprintf(stderr, " %02x", response[i]);
+        fprintf(stderr, " state %d\n", sd->state);
     } else {
         DPRINTF("No response %d\n", sd->state);
     }
-- 
1.8.0.1

[Qemu-devel] [PATCH 02/13] configure: Remove stray debug output

[Stefan Hajnoczi]

From: Peter Maydell <peter.maydell@linaro.org>

Rather than printing a message saying we're silently falling
back to gthread coroutines when running on MacOS, actually
do it silently.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 configure | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configure b/configure
index 994f731..447e6ed 100755
--- a/configure
+++ b/configure
@@ -2969,8 +2969,6 @@ EOF
     else
 	coroutine_backend=gthread
     fi
-  else
-    echo "Silently falling back into gthread backend under darwin"
   fi
 elif test "$coroutine" = "gthread" ; then
   coroutine_backend=gthread
-- 
1.8.0.1

[Qemu-devel] [PATCH 03/13] Fix spelling (prefered -> preferred)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 configure       | 2 +-
 net/tap-win32.c | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 447e6ed..79605d2 100755
--- a/configure
+++ b/configure
@@ -2130,7 +2130,7 @@ if test "$pixman" = "system"; then
 else
   if test ! -d ${source_path}/pixman/pixman; then
     echo "ERROR: pixman not present. Your options:"
-    echo "  (1) Prefered: Install the pixman devel package (any recent"
+    echo "  (1) Preferred: Install the pixman devel package (any recent"
     echo "      distro should have packages as Xorg needs pixman too)."
     echo "  (2) Fetch the pixman submodule, using:"
     echo "      git submodule update --init pixman"
diff --git a/net/tap-win32.c b/net/tap-win32.c
index 8d2d32b..f9bd741 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -565,7 +565,7 @@ static void tap_win32_free_buffer(tap_win32_overlapped_t *overlapped,
 }
 
 static int tap_win32_open(tap_win32_overlapped_t **phandle,
-                          const char *prefered_name)
+                          const char *preferred_name)
 {
     char device_path[256];
     char device_guid[0x100];
@@ -581,8 +581,9 @@ static int tap_win32_open(tap_win32_overlapped_t **phandle,
     DWORD version_len;
     DWORD idThread;
 
-    if (prefered_name != NULL)
-        snprintf(name_buffer, sizeof(name_buffer), "%s", prefered_name);
+    if (preferred_name != NULL) {
+        snprintf(name_buffer, sizeof(name_buffer), "%s", preferred_name);
+    }
 
     rc = get_device_guid(device_guid, sizeof(device_guid), name_buffer, sizeof(name_buffer));
     if (rc)
-- 
1.8.0.1

[Qemu-devel] [PATCH 04/13] Fix comments (adress -> address, layed -> laid, wierd -> weird)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Remove also a duplicated 'the'.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 slirp/ip_icmp.c | 2 +-
 tcg/tcg.h       | 4 ++--
 uri.c           | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c
index d571fd0..9f1cb08 100644
--- a/slirp/ip_icmp.c
+++ b/slirp/ip_icmp.c
@@ -352,7 +352,7 @@ icmp_error(struct mbuf *msrc, u_char type, u_char code, int minsize,
 
   ip->ip_ttl = MAXTTL;
   ip->ip_p = IPPROTO_ICMP;
-  ip->ip_dst = ip->ip_src;    /* ip adresses */
+  ip->ip_dst = ip->ip_src;    /* ip addresses */
   ip->ip_src = m->slirp->vhost_addr;
 
   (void ) ip_output((struct socket *)NULL, m);
diff --git a/tcg/tcg.h b/tcg/tcg.h
index 9481e35..e7de8c0 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -290,8 +290,8 @@ typedef int TCGv_i64;
 #define TCG_CALL_DUMMY_TCGV     MAKE_TCGV_I32(-1)
 #define TCG_CALL_DUMMY_ARG      ((TCGArg)(-1))
 
-/* Conditions.  Note that these are layed out for easy manipulation by
-   the the functions below:
+/* Conditions.  Note that these are laid out for easy manipulation by
+   the functions below:
      bit 0 is used for inverting;
      bit 1 is signed,
      bit 2 is unsigned,
diff --git a/uri.c b/uri.c
index dd922de..138547b 100644
--- a/uri.c
+++ b/uri.c
@@ -432,7 +432,7 @@ rfc3986_parse_host(URI *uri, const char **str)
 
     host = cur;
     /*
-     * IPv6 and future adressing scheme are enclosed between brackets
+     * IPv6 and future addressing scheme are enclosed between brackets
      */
     if (*cur == '[') {
         cur++;
@@ -1917,7 +1917,7 @@ done:
  *     http://site1.com/docs/pic1.gif   http://site1.com/docs/pic1.gif
  *
  *
- * Note: if the URI reference is really wierd or complicated, it may be
+ * Note: if the URI reference is really weird or complicated, it may be
  *       worthwhile to first convert it into a "nice" one by calling
  *       uri_resolve (using 'base') before calling this routine,
  *       since this routine (for reasonable efficiency) assumes URI has
-- 
1.8.0.1

[Qemu-devel] [PATCH 05/13] s390x: Spelling fixes (endianess -> endianness, occured -> occurred)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Replace also "write into" by "write to".

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/s390x/sclp.h        | 4 ++--
 hw/s390x/sclpconsole.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/s390x/sclp.h b/hw/s390x/sclp.h
index fe89dad..231a38a 100644
--- a/hw/s390x/sclp.h
+++ b/hw/s390x/sclp.h
@@ -51,7 +51,7 @@
 
 /*
  * Normally packed structures are not the right thing to do, since all code
- * must take care of endianess. We cant use ldl_phys and friends for two
+ * must take care of endianness. We cannot use ldl_phys and friends for two
  * reasons, though:
  * - some of the embedded structures below the SCCB can appear multiple times
  *   at different locations, so there is no fixed offset
@@ -60,7 +60,7 @@
  *   alter the structure while we parse it. We cannot use ldl_p and friends
  *   either without doing pointer arithmetics
  * So we have to double check that all users of sclp data structures use the
- * right endianess wrappers.
+ * right endianness wrappers.
  */
 typedef struct SCCBHeader {
     uint16_t length;
diff --git a/hw/s390x/sclpconsole.c b/hw/s390x/sclpconsole.c
index 0ec5623..fece878 100644
--- a/hw/s390x/sclpconsole.c
+++ b/hw/s390x/sclpconsole.c
@@ -179,8 +179,8 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr,
 }
 
 /* triggered by SCLP's write_event_data
- *  - write console data into character layer
- *  returns < 0 if an error occured
+ *  - write console data to character layer
+ *  returns < 0 if an error occurred
  */
 static ssize_t write_console_data(SCLPEvent *event, const uint8_t *buf,
                                   size_t len)
-- 
1.8.0.1

[Qemu-devel] [PATCH 06/13] target-alpha: Remove t0, t1 from CPUAlphaState

[Stefan Hajnoczi]

From: Richard Henderson <rth@twiddle.net>

These fields are no longer (or were never?) used.

Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 target-alpha/cpu.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index 34221fb..9939d61 100644
--- a/target-alpha/cpu.h
+++ b/target-alpha/cpu.h
@@ -280,13 +280,6 @@ struct CPUAlphaState {
     struct QEMUTimer *alarm_timer;
     uint64_t alarm_expire;
 
-#if TARGET_LONG_BITS > HOST_LONG_BITS
-    /* temporary fixed-point registers
-     * used to emulate 64 bits target on 32 bits hosts
-     */
-    target_ulong t0, t1;
-#endif
-
     /* Those resources are used only in QEMU core */
     CPU_COMMON
 
-- 
1.8.0.1

[Qemu-devel] [PATCH 07/13] target-m68k: Remove t1 from CPUM68KState

[Stefan Hajnoczi]

From: Richard Henderson <rth@twiddle.net>

This field is no longer used.

Cc: Paul Brook <paul@codesourcery.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 target-m68k/cpu.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h
index 780e2c9..f4fcdee 100644
--- a/target-m68k/cpu.h
+++ b/target-m68k/cpu.h
@@ -103,9 +103,6 @@ typedef struct CPUM68KState {
     uint32_t rambar0;
     uint32_t cacr;
 
-    /* ??? remove this.  */
-    uint32_t t1;
-
     int pending_vector;
     int pending_level;
 
-- 
1.8.0.1

[Qemu-devel] [PATCH 08/13] target-sparc: Remove t0, t1 from CPUSPARCState

[Stefan Hajnoczi]

From: Richard Henderson <rth@twiddle.net>

These fields are no longer used.

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 target-sparc/cpu.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h
index 042d52a..375f20a 100644
--- a/target-sparc/cpu.h
+++ b/target-sparc/cpu.h
@@ -392,7 +392,6 @@ struct CPUSPARCState {
     target_ulong cc_dst;
     uint32_t cc_op;
 
-    target_ulong t0, t1; /* temporaries live across basic blocks */
     target_ulong cond; /* conditional branch result (XXX: save it in a
                           temporary register when possible) */
 
-- 
1.8.0.1

[Qemu-devel] [PATCH 09/13] arm: a9mpcore: remove un-used ptimer_iomem field

[Stefan Hajnoczi]

From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

I'm guessing this is a hangover from a previous coreification of the mptimer
sub-module. This field is completely unused - removed.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/a9mpcore.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c
index 824ff0a..f802de0 100644
--- a/hw/a9mpcore.c
+++ b/hw/a9mpcore.c
@@ -19,7 +19,6 @@ typedef struct a9mp_priv_state {
     uint32_t old_timer_status[8];
     uint32_t num_cpu;
     MemoryRegion scu_iomem;
-    MemoryRegion ptimer_iomem;
     MemoryRegion container;
     DeviceState *mptimer;
     DeviceState *gic;
-- 
1.8.0.1

[Qemu-devel] [PATCH 10/13] Clean up pci_drive_hot_add()'s use of BlockInterfaceType

[Stefan Hajnoczi]

From: Markus Armbruster <armbru@redhat.com>

pci_drive_hot_add() parameter type has the wrong type: int instead of
BlockInterfaceType.  It's actually redundant, so we can just drop it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/device-hotplug.c | 11 ++++-------
 hw/pci-hotplug.c    |  7 +++----
 sysemu.h            |  3 +--
 3 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/hw/device-hotplug.c b/hw/device-hotplug.c
index eec0fe3..6d9c080 100644
--- a/hw/device-hotplug.c
+++ b/hw/device-hotplug.c
@@ -49,18 +49,16 @@ DriveInfo *add_init_drive(const char *optstr)
 }
 
 #if !defined(TARGET_I386)
-int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
-                      DriveInfo *dinfo, int type)
+int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo)
 {
     /* On non-x86 we don't do PCI hotplug */
-    monitor_printf(mon, "Can't hot-add drive to type %d\n", type);
+    monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type);
     return -1;
 }
 #endif
 
 void drive_hot_add(Monitor *mon, const QDict *qdict)
 {
-    int type;
     DriveInfo *dinfo = NULL;
     const char *opts = qdict_get_str(qdict, "opts");
 
@@ -72,14 +70,13 @@ void drive_hot_add(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "Parameter addr not supported\n");
         goto err;
     }
-    type = dinfo->type;
 
-    switch (type) {
+    switch (dinfo->type) {
     case IF_NONE:
         monitor_printf(mon, "OK\n");
         break;
     default:
-        if (pci_drive_hot_add(mon, qdict, dinfo, type)) {
+        if (pci_drive_hot_add(mon, qdict, dinfo)) {
             goto err;
         }
     }
diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index 0ca5546..3bcfdcc 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -111,15 +111,14 @@ static int scsi_hot_add(Monitor *mon, DeviceState *adapter,
     return 0;
 }
 
-int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
-                      DriveInfo *dinfo, int type)
+int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo)
 {
     int dom, pci_bus;
     unsigned slot;
     PCIDevice *dev;
     const char *pci_addr = qdict_get_str(qdict, "pci_addr");
 
-    switch (type) {
+    switch (dinfo->type) {
     case IF_SCSI:
         if (pci_read_devaddr(mon, pci_addr, &dom, &pci_bus, &slot)) {
             goto err;
@@ -135,7 +134,7 @@ int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
         }
         break;
     default:
-        monitor_printf(mon, "Can't hot-add drive to type %d\n", type);
+        monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type);
         goto err;
     }
 
diff --git a/sysemu.h b/sysemu.h
index f5ac664..c1b370b 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -145,8 +145,7 @@ extern unsigned int nb_prom_envs;
 
 /* pci-hotplug */
 void pci_device_hot_add(Monitor *mon, const QDict *qdict);
-int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
-                      DriveInfo *dinfo, int type);
+int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo);
 void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
 
 /* generic hotplug */
-- 
1.8.0.1

[Qemu-devel] [PATCH 11/13] Fix spelling in comments and documentation

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

These spelling bugs were found by codespell:

supressing -> suppressing
transfered -> transferred

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/usb.h                      | 6 +++---
 tests/qemu-iotests/iotests.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/usb.h b/hw/usb.h
index 7d6de69..f05eb17 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -282,7 +282,7 @@ typedef struct USBDeviceClass {
      * Called from handle_packet().
      *
      * Status gets stored in p->status, and if p->status == USB_RET_SUCCESS
-     * then the number of bytes transfered is stored in p->actual_length
+     * then the number of bytes transferred is stored in p->actual_length
      */
     void (*handle_control)(USBDevice *dev, USBPacket *p, int request, int value,
                            int index, int length, uint8_t *data);
@@ -292,7 +292,7 @@ typedef struct USBDeviceClass {
      * Called from handle_packet().
      *
      * Status gets stored in p->status, and if p->status == USB_RET_SUCCESS
-     * then the number of bytes transfered is stored in p->actual_length
+     * then the number of bytes transferred is stored in p->actual_length
      */
     void (*handle_data)(USBDevice *dev, USBPacket *p);
 
@@ -358,7 +358,7 @@ struct USBPacket {
     bool short_not_ok;
     bool int_req;
     int status; /* USB_RET_* status code */
-    int actual_length; /* Number of bytes actually transfered */
+    int actual_length; /* Number of bytes actually transferred */
     /* Internal use by the USB layer.  */
     USBPacketState state;
     USBCombinedPacket *combined;
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index b2eaf20..0be5c7e 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -43,7 +43,7 @@ def qemu_img(*args):
     return subprocess.call(qemu_img_args + list(args), stdin=devnull, stdout=devnull)
 
 def qemu_img_verbose(*args):
-    '''Run qemu-img without supressing its output and return the exit code'''
+    '''Run qemu-img without suppressing its output and return the exit code'''
     return subprocess.call(qemu_img_args + list(args))
 
 def qemu_io(*args):
-- 
1.8.0.1

[Qemu-devel] [PATCH 12/13] qemu-options: Fix space at EOL

[Stefan Hajnoczi]

From: Michal Privoznik <mprivozn@redhat.com>

There's no need to add a space at the end of line.
Moreover, it can make problems in some projects that
store the help output into a file (and run couple of
tests based on that) and have space at EOL forbidden.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index de43b1b..231cc4f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1331,7 +1331,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
     "                connect the host TAP network interface to VLAN 'n'\n"
 #else
     "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h][,vhostforce=on|off]\n"
-    "                connect the host TAP network interface to VLAN 'n' \n"
+    "                connect the host TAP network interface to VLAN 'n'\n"
     "                use network scripts 'file' (default=" DEFAULT_NETWORK_SCRIPT ")\n"
     "                to configure it and 'dfile' (default=" DEFAULT_NETWORK_DOWN_SCRIPT ")\n"
     "                to deconfigure it\n"
-- 
1.8.0.1

[Qemu-devel] [PATCH 13/13] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path

[Stefan Hajnoczi]

From: Markus Armbruster <armbru@redhat.com>

Harmless, because we the error inevitably leads to another, fatal one
in pc_system_flash_init(): PC system firmware (pflash) not available.
Fix it anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/pc_sysfw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c
index 9d7c5f4..40bced2 100644
--- a/hw/pc_sysfw.c
+++ b/hw/pc_sysfw.c
@@ -98,7 +98,9 @@ static void pc_fw_add_pflash_drv(void)
       return;
     }
 
-    drive_init(opts, machine->use_scsi);
+    if (!drive_init(opts, machine->use_scsi)) {
+        qemu_opts_del(opts);
+    }
 }
 
 static void pc_system_flash_init(MemoryRegion *rom_memory,
-- 
1.8.0.1

Re: [Qemu-devel] [PULL 00/13] Trivial patches for 2 to 7 November

[Anthony Liguori]

Stefan Hajnoczi <stefanha@redhat.com> writes:

> These patches were mostly submitted during the 1.3 hard freeze.  I'll catch up
> with the new trivial patches next week.
>
> The following changes since commit 80625b97b52836b944a6438e8e3e9d992e6a00b6:
>
>   xilinx_uartlite: Accept input after rx FIFO pop (2012-12-05 09:20:36 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git trivial-patches
>

Pulled. Thanks.

Regards,

Anthony Liguori

> for you to fetch changes up to 654598c944aa31cdbea435bd468055af9c918d16:
>
>   pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path (2012-12-07 12:34:12 +0100)
>
> ----------------------------------------------------------------
> Markus Armbruster (2):
>       Clean up pci_drive_hot_add()'s use of BlockInterfaceType
>       pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path
>
> Michal Privoznik (1):
>       qemu-options: Fix space at EOL
>
> Petar Jovanovic (2):
>       target-mips: Fix incorrect code and test for INSV
>       target-mips: Fix incorrect shift for SHILO and SHILOV
>
> Peter Crosthwaite (2):
>       sd: Send debug printfery to stderr not stdout
>       arm: a9mpcore: remove un-used ptimer_iomem field
>
> Peter Maydell (1):
>       configure: Remove stray debug output
>
> Richard Henderson (3):
>       target-alpha: Remove t0, t1 from CPUAlphaState
>       target-m68k: Remove t1 from CPUM68KState
>       target-sparc: Remove t0, t1 from CPUSPARCState
>
> Stefan Weil (4):
>       Fix spelling (prefered -> preferred)
>       Fix comments (adress -> address, layed -> laid, wierd -> weird)
>       s390x: Spelling fixes (endianess -> endianness, occured -> occurred)
>       Fix spelling in comments and documentation
>
>  configure                          |  4 +---
>  hw/a9mpcore.c                      |  1 -
>  hw/device-hotplug.c                | 11 ++++-------
>  hw/pc_sysfw.c                      |  4 +++-
>  hw/pci-hotplug.c                   |  7 +++----
>  hw/s390x/sclp.h                    |  4 ++--
>  hw/s390x/sclpconsole.c             |  4 ++--
>  hw/sd.c                            |  4 ++--
>  hw/usb.h                           |  6 +++---
>  net/tap-win32.c                    |  7 ++++---
>  qemu-options.hx                    |  2 +-
>  slirp/ip_icmp.c                    |  2 +-
>  sysemu.h                           |  3 +--
>  target-alpha/cpu.h                 |  7 -------
>  target-m68k/cpu.h                  |  3 ---
>  target-mips/dsp_helper.c           | 19 ++++++++++---------
>  target-sparc/cpu.h                 |  1 -
>  tcg/tcg.h                          |  4 ++--
>  tests/qemu-iotests/iotests.py      |  2 +-
>  tests/tcg/mips/mips32-dsp/insv.c   |  2 +-
>  tests/tcg/mips/mips32-dsp/shilo.c  | 18 ++++++++++++++++++
>  tests/tcg/mips/mips32-dsp/shilov.c | 20 ++++++++++++++++++++
>  uri.c                              |  4 ++--
>  23 files changed, 81 insertions(+), 58 deletions(-)
>
> -- 
> 1.8.0.1