From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 1/4] multiboot: use FWCfgState* as argument instead of void*
Date: Fri, 7 Dec 2012 14:07:33 -0200 [thread overview]
Message-ID: <1354896456-21120-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1354896456-21120-1-git-send-email-ehabkost@redhat.com>
There's no point in using void* if we can simply use the right type for
the argument (FWCfgState*).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Anthony Liguori <aliguori@us.ibm.com>
---
hw/multiboot.c | 2 +-
hw/multiboot.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 09ec5b2..06bbf4c 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -124,7 +124,7 @@ static void mb_add_mod(MultibootState *s,
s->mb_mods_count++;
}
-int load_multiboot(void *fw_cfg,
+int load_multiboot(FWCfgState *fw_cfg,
FILE *f,
const char *kernel_filename,
const char *initrd_filename,
diff --git a/hw/multiboot.h b/hw/multiboot.h
index 98fb1b7..33c82b1 100644
--- a/hw/multiboot.h
+++ b/hw/multiboot.h
@@ -1,7 +1,9 @@
#ifndef QEMU_MULTIBOOT_H
#define QEMU_MULTIBOOT_H
-int load_multiboot(void *fw_cfg,
+#include "fw_cfg.h"
+
+int load_multiboot(FWCfgState *fw_cfg,
FILE *f,
const char *kernel_filename,
const char *initrd_filename,
--
1.7.11.7
next prev parent reply other threads:[~2012-12-07 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 16:07 [Qemu-devel] [PATCH 0/4] use FWCfgState* instead of void* for fw_cfg data Eduardo Habkost
2012-12-07 16:07 ` Eduardo Habkost [this message]
2012-12-07 16:07 ` [Qemu-devel] [PATCH 2/4] pc: " Eduardo Habkost
2012-12-07 16:07 ` [Qemu-devel] [PATCH 3/4] ppc: " Eduardo Habkost
2012-12-07 18:32 ` Alexander Graf
2012-12-07 16:07 ` [Qemu-devel] [PATCH 4/4] sparc: " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354896456-21120-2-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).