From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH 4/4] sparc: use FWCfgState* instead of void* for fw_cfg data
Date: Fri, 7 Dec 2012 14:07:36 -0200 [thread overview]
Message-ID: <1354896456-21120-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1354896456-21120-1-git-send-email-ehabkost@redhat.com>
There's no point in using void* if all functions dealing with that data
use FWCfgState*.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Blue Swirl <blauwirbel@gmail.com>
---
hw/sun4m.c | 6 +++---
hw/sun4u.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/sun4m.c b/hw/sun4m.c
index 1a78676..efcd5dd 100644
--- a/hw/sun4m.c
+++ b/hw/sun4m.c
@@ -866,7 +866,7 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef, ram_addr_t RAM_size,
qemu_irq *cpu_halt;
unsigned long kernel_size;
DriveInfo *fd[MAX_FD];
- void *fw_cfg;
+ FWCfgState *fw_cfg;
unsigned int num_vsimms;
/* init CPUs */
@@ -1576,7 +1576,7 @@ static void sun4d_hw_init(const struct sun4d_hwdef *hwdef, ram_addr_t RAM_size,
espdma_irq, ledma_irq;
qemu_irq esp_reset, dma_enable;
unsigned long kernel_size;
- void *fw_cfg;
+ FWCfgState *fw_cfg;
DeviceState *dev;
/* init CPUs */
@@ -1776,7 +1776,7 @@ static void sun4c_hw_init(const struct sun4c_hwdef *hwdef, ram_addr_t RAM_size,
qemu_irq fdc_tc;
unsigned long kernel_size;
DriveInfo *fd[MAX_FD];
- void *fw_cfg;
+ FWCfgState *fw_cfg;
DeviceState *dev;
unsigned int i;
diff --git a/hw/sun4u.c b/hw/sun4u.c
index b2b51e3..8a7f52d 100644
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -812,7 +812,7 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
qemu_irq *ivec_irqs, *pbm_irqs;
DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
DriveInfo *fd[MAX_FD];
- void *fw_cfg;
+ FWCfgState *fw_cfg;
/* init CPUs */
cpu = cpu_devinit(cpu_model, hwdef);
--
1.7.11.7
prev parent reply other threads:[~2012-12-07 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 16:07 [Qemu-devel] [PATCH 0/4] use FWCfgState* instead of void* for fw_cfg data Eduardo Habkost
2012-12-07 16:07 ` [Qemu-devel] [PATCH 1/4] multiboot: use FWCfgState* as argument instead of void* Eduardo Habkost
2012-12-07 16:07 ` [Qemu-devel] [PATCH 2/4] pc: use FWCfgState* instead of void* for fw_cfg data Eduardo Habkost
2012-12-07 16:07 ` [Qemu-devel] [PATCH 3/4] ppc: " Eduardo Habkost
2012-12-07 18:32 ` Alexander Graf
2012-12-07 16:07 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354896456-21120-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).