From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThMEO-0007m3-7T for qemu-devel@nongnu.org; Sat, 08 Dec 2012 10:22:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThMEN-0007nB-Ax for qemu-devel@nongnu.org; Sat, 08 Dec 2012 10:22:20 -0500 Received: from smtp6-g21.free.fr ([2a01:e0c:1:1599::15]:35551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThMEM-0007ms-OD for qemu-devel@nongnu.org; Sat, 08 Dec 2012 10:22:19 -0500 From: Laurent Vivier Date: Sat, 8 Dec 2012 16:22:11 +0100 Message-Id: <1354980131-19274-1-git-send-email-laurent@vivier.eu> Subject: [Qemu-devel] [PATCH] linux-user: allow to use sudo in guest qemu must have suid/gid bit and root owner/group List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , Laurent Vivier Signed-off-by: Laurent Vivier --- linux-user/linuxload.c | 12 +++++++----- linux-user/main.c | 3 +++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c index 381ab89..0fccf58 100644 --- a/linux-user/linuxload.c +++ b/linux-user/linuxload.c @@ -58,11 +58,6 @@ static int prepare_binprm(struct linux_binprm *bprm) bprm->e_uid = geteuid(); bprm->e_gid = getegid(); - /* Set-uid? */ - if(mode & S_ISUID) { - bprm->e_uid = st.st_uid; - } - /* Set-gid? */ /* * If setgid is set but no group execute bit then this @@ -72,6 +67,13 @@ static int prepare_binprm(struct linux_binprm *bprm) if ((mode & (S_ISGID | S_IXGRP)) == (S_ISGID | S_IXGRP)) { bprm->e_gid = st.st_gid; } + setresgid(getgid(), bprm->e_gid, bprm->e_gid); + + /* Set-uid? */ + if(mode & S_ISUID) { + bprm->e_uid = st.st_uid; + } + setresuid(getuid(), bprm->e_uid, bprm->e_uid); retval = read(bprm->fd, bprm->buf, BPRM_BUF_SIZE); if (retval < 0) { diff --git a/linux-user/main.c b/linux-user/main.c index 25e35cd..3cddb2e 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3400,6 +3400,9 @@ int main(int argc, char **argv, char **envp) int i; int ret; + seteuid(getuid()); + setegid(getgid()); + module_call_init(MODULE_INIT_QOM); qemu_cache_utils_init(envp); -- 1.7.10.4