* [Qemu-devel] [PATCH] target-arm: fix target CPUs on ARM GIC
@ 2012-12-10 3:32 dsl
2012-12-11 11:51 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: dsl @ 2012-12-10 3:32 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, paul, Daniel Sangorrin
Fix a bug on the ARM GIC model where interrupts are not
set pending on the correct target CPUs when they are
triggered by writes to the Interrupt Set Enable or
Set Pending registers.
Signed-off-by: Daniel Sangorrin <dsl@ertl.jp>
---
hw/arm_gic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index f9e423f..97b0677 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -374,7 +374,8 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
value = 0xff;
for (i = 0; i < 8; i++) {
if (value & (1 << i)) {
- int mask = (irq < GIC_INTERNAL) ? (1 << cpu) : GIC_TARGET(irq);
+ int mask =
+ (irq < GIC_INTERNAL) ? (1 << cpu) : GIC_TARGET(irq + i);
int cm = (irq < GIC_INTERNAL) ? (1 << cpu) : ALL_CPU_MASK;
if (!GIC_TEST_ENABLED(irq + i, cm)) {
@@ -417,7 +418,7 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
for (i = 0; i < 8; i++) {
if (value & (1 << i)) {
- GIC_SET_PENDING(irq + i, GIC_TARGET(irq));
+ GIC_SET_PENDING(irq + i, GIC_TARGET(irq + i));
}
}
} else if (offset < 0x300) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: fix target CPUs on ARM GIC
2012-12-10 3:32 [Qemu-devel] [PATCH] target-arm: fix target CPUs on ARM GIC dsl
@ 2012-12-11 11:51 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2012-12-11 11:51 UTC (permalink / raw)
To: dsl; +Cc: qemu-devel, paul
On 10 December 2012 03:32, <dsl@ertl.jp> wrote:
> Fix a bug on the ARM GIC model where interrupts are not
> set pending on the correct target CPUs when they are
> triggered by writes to the Interrupt Set Enable or
> Set Pending registers.
>
> Signed-off-by: Daniel Sangorrin <dsl@ertl.jp>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Thanks -- applied to the arm-devs.next tree.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-11 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 3:32 [Qemu-devel] [PATCH] target-arm: fix target CPUs on ARM GIC dsl
2012-12-11 11:51 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).