From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThxME-0000Nf-NR for qemu-devel@nongnu.org; Mon, 10 Dec 2012 02:00:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThxMB-0005SE-D0 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 02:00:54 -0500 From: John Spencer Date: Mon, 10 Dec 2012 07:59:46 +0100 Message-Id: <1355122786-29243-4-git-send-email-maillist-qemu@barfooze.de> In-Reply-To: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> References: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> Subject: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: qemu-devel@nongnu.org, John Spencer this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header. Signed-off-by: John Spencer --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fabbcd7..665316e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -585,7 +586,6 @@ extern int personality(int); extern int flock(int, int); extern int setfsuid(int); extern int setfsgid(int); -extern int setgroups(int, gid_t *); /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM -- 1.7.3.4