From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti1yI-0004fA-Qn for qemu-devel@nongnu.org; Mon, 10 Dec 2012 06:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti1yH-0000oR-1s for qemu-devel@nongnu.org; Mon, 10 Dec 2012 06:56:30 -0500 Received: from mel.act-europe.fr ([194.98.77.210]:53615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti1yG-0000oA-S8 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 06:56:28 -0500 From: Fabien Chouteau Date: Mon, 10 Dec 2012 12:56:22 +0100 Message-Id: <1355140582-5354-1-git-send-email-chouteau@adacore.com> Subject: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, blauwirbel@gmail.com, stefanha@redhat.com An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau --- block/raw-win32.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 0c05c58..ce207a3 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -303,13 +303,24 @@ static int raw_truncate(BlockDriverState *bs, int64_t offset) { BDRVRawState *s = bs->opaque; LONG low, high; + DWORD dwPtrLow; low = offset; high = offset >> 32; - if (!SetFilePointer(s->hfile, low, &high, FILE_BEGIN)) - return -EIO; - if (!SetEndOfFile(s->hfile)) + + /* + * An error has occurred if the return value is INVALID_SET_FILE_POINTER + * and GetLastError doesn't return NO_ERROR. + */ + dwPtrLow = SetFilePointer(s->hfile, low, &high, FILE_BEGIN); + if (dwPtrLow == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) { + fprintf(stderr, "SetFilePointer error: %d\n", GetLastError()); + return -EIO; + } + if (SetEndOfFile(s->hfile) == 0) { + fprintf(stderr, "SetEndOfFile error: %d\n", GetLastError()); return -EIO; + } return 0; } -- 1.7.9.5