From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
David Gibson <david@gibson.dropbear.id.au>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [RFC 0/4] virtio: stabilize migration format
Date: Mon, 10 Dec 2012 08:29:46 -0600 [thread overview]
Message-ID: <1355149790-8125-1-git-send-email-aliguori@us.ibm.com> (raw)
This series replaces:
qemu_put_buffer(f, (unsigned char*)&req->elem, sizeof(req->elem));
With code that properly saves out each element of the structure using
a well defined endian format. Migration is broken today from big endian to
little endian hosts.
There's no way to fix this problem without bumping the migration version
number and that's exactly what we do here. By bumping the migration version
number, we do break new->old migration but that's unavoidable right now.
In order to support old->new, we assume that all incoming data is in little
endian. The final patch adds a check to the load routines to fail old->new
on big endian hosts where this may not have been true.
I've not tested this thoroughly enough to apply yet but wanted to share.
---
hw/virtio-blk.c | 22 +++++---
hw/virtio-serial-bus.c | 19 +++----
hw/virtio.c | 123 +++++++++++++++++++++++++++++++++++++++++++++++++
hw/virtio.h | 4 +
qemu-file.h | 7 ++
savevm.c | 45 +++++++++++++++++
6 files changed, 201 insertions(+), 19 deletions(-)
next reply other threads:[~2012-12-10 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 14:29 Anthony Liguori [this message]
2012-12-10 14:29 ` [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines Anthony Liguori
2012-12-10 14:33 ` Peter Maydell
2012-12-10 15:24 ` Anthony Liguori
2012-12-10 14:29 ` [Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements Anthony Liguori
2012-12-14 11:46 ` Paolo Bonzini
2012-12-14 13:54 ` Anthony Liguori
2012-12-10 14:29 ` [Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format Anthony Liguori
2012-12-11 0:32 ` Rusty Russell
2012-12-11 0:54 ` Anthony Liguori
2012-12-14 0:57 ` Rusty Russell
2012-12-14 11:50 ` Paolo Bonzini
2012-12-14 13:59 ` Anthony Liguori
2012-12-10 14:29 ` [Qemu-devel] [PATCH 4/4] virtio: bump migration version number Anthony Liguori
2012-12-11 9:02 ` [Qemu-devel] [RFC 0/4] virtio: stabilize migration format Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355149790-8125-1-git-send-email-aliguori@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).