From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiDEo-0006K8-KL for qemu-devel@nongnu.org; Mon, 10 Dec 2012 18:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiDEm-0007dc-8D for qemu-devel@nongnu.org; Mon, 10 Dec 2012 18:58:18 -0500 Date: Mon, 10 Dec 2012 17:42:54 -0600 From: Scott Wood References: <1354974282-1915-1-git-send-email-agraf@suse.de> <1354974282-1915-11-git-send-email-agraf@suse.de> In-Reply-To: <1354974282-1915-11-git-send-email-agraf@suse.de> (from agraf@suse.de on Sat Dec 8 07:44:33 2012) Message-ID: <1355182974.5334.19@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 10/19] openpic: remove unused type variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org List" , qemu-devel qemu-devel On 12/08/2012 07:44:33 AM, Alexander Graf wrote: > The openpic source irqs are carrying around a type indicator that > is never accessed by anything. Remove it. >=20 > Signed-off-by: Alexander Graf > --- > hw/openpic.c | 27 ++------------------------- > 1 files changed, 2 insertions(+), 25 deletions(-) >=20 > diff --git a/hw/openpic.c b/hw/openpic.c > index e4ef23d..d252b2b 100644 > --- a/hw/openpic.c > +++ b/hw/openpic.c > @@ -167,13 +167,6 @@ static uint32_t openpic_cpu_read_internal(void =20 > *opaque, hwaddr addr, > static void openpic_cpu_write_internal(void *opaque, hwaddr addr, > uint32_t val, int idx); >=20 > -enum { > - IRQ_EXTERNAL =3D 0x01, > - IRQ_INTERNAL =3D 0x02, > - IRQ_TIMER =3D 0x04, > - IRQ_SPECIAL =3D 0x08, > -}; We may want to distinguish based on something like this in the future =20 -- for example, internal interrupts on FSL MPIC don't have a "sense" =20 bit. -Scott=