From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiDXQ-0004c7-To for qemu-devel@nongnu.org; Mon, 10 Dec 2012 19:17:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiDXO-0004Rq-GQ for qemu-devel@nongnu.org; Mon, 10 Dec 2012 19:17:32 -0500 Date: Mon, 10 Dec 2012 17:47:11 -0600 From: Scott Wood References: <1354974282-1915-1-git-send-email-agraf@suse.de> <1354974282-1915-15-git-send-email-agraf@suse.de> In-Reply-To: <1354974282-1915-15-git-send-email-agraf@suse.de> (from agraf@suse.de on Sat Dec 8 07:44:37 2012) Message-ID: <1355183231.5334.20@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/19] openpic: convert to qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org List" , qemu-devel qemu-devel On 12/08/2012 07:44:37 AM, Alexander Graf wrote: > This patch converts the OpenPIC device to qdev. Along the way it > renames the "openpic" target to "raven" and the "mpic" target to > "mpc8544", to better reflect the actual models they implement. >=20 > This way we have a generic OpenPIC device now that can handle > different flavors of the OpenPIC specification. I'd rather not see the expansion of "mpc8544" hardcoding, especially =20 since it's not really modelling an MPIC as found in an mpc8544, but =20 rather half-implementing a generic Freescale MPIC. Can we just call it =20 a Freescale MPIC, and then work on parameterizing it properly (starting =20 with MPIC version)? -Scott=