From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Don@CloudSwitch.com, afaerber@suse.de, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 4/6] target-i386: setting default 'vendor' is obsolete, remove it
Date: Tue, 11 Dec 2012 11:11:04 +0100 [thread overview]
Message-ID: <1355220666-31722-5-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1355220666-31722-1-git-send-email-imammedo@redhat.com>
since cpu_def config is not supported anymore and all remainig sources now
always set x86_def_t.vendor[123] fields remove setting default vendor to
simplify future refactoring.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
target-i386/cpu.c | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1497980..99fd3f3 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1539,15 +1539,10 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
if (cpu_x86_parse_featurestr(def, features) < 0) {
goto error;
}
- if (def->vendor1) {
- env->cpuid_vendor1 = def->vendor1;
- env->cpuid_vendor2 = def->vendor2;
- env->cpuid_vendor3 = def->vendor3;
- } else {
- env->cpuid_vendor1 = CPUID_VENDOR_INTEL_1;
- env->cpuid_vendor2 = CPUID_VENDOR_INTEL_2;
- env->cpuid_vendor3 = CPUID_VENDOR_INTEL_3;
- }
+ assert(def->vendor1);
+ env->cpuid_vendor1 = def->vendor1;
+ env->cpuid_vendor2 = def->vendor2;
+ env->cpuid_vendor3 = def->vendor3;
env->cpuid_vendor_override = def->vendor_override;
object_property_set_int(OBJECT(cpu), def->level, "level", &error);
object_property_set_int(OBJECT(cpu), def->family, "family", &error);
--
1.7.1
next prev parent reply other threads:[~2012-12-11 10:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:11 [Qemu-devel] [PATCH 0/6] x86 CPU cleanup (wave 2) Igor Mammedov
2012-12-11 10:11 ` [Qemu-devel] [PATCH 1/6] target-i386: filter out not TCG features if running without kvm at realize time Igor Mammedov
2012-12-11 13:26 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features " Igor Mammedov
2012-12-11 13:31 ` Eduardo Habkost
2012-12-11 13:41 ` Igor Mammedov
2012-12-11 14:08 ` Igor Mammedov
2012-12-11 14:25 ` Eduardo Habkost
2012-12-11 14:18 ` [Qemu-devel] [PATCH 2/6 v3] " Igor Mammedov
2012-12-11 14:26 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 3/6] target-i386: explicitly set vendor for each built-in cpudef Igor Mammedov
2012-12-11 13:32 ` Eduardo Habkost
2012-12-11 10:11 ` Igor Mammedov [this message]
2012-12-11 13:32 ` [Qemu-devel] [PATCH 4/6] target-i386: setting default 'vendor' is obsolete, remove it Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 5/6] target-i386: move setting defaults out of cpu_x86_parse_featurestr() Igor Mammedov
2012-12-11 13:33 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 6/6] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-12-11 13:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355220666-31722-5-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=Don@CloudSwitch.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).