From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Don@CloudSwitch.com, afaerber@suse.de, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 5/6] target-i386: move setting defaults out of cpu_x86_parse_featurestr()
Date: Tue, 11 Dec 2012 11:11:05 +0100 [thread overview]
Message-ID: <1355220666-31722-6-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1355220666-31722-1-git-send-email-imammedo@redhat.com>
No functional change, needed for simplifying convertion to properties.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
target-i386/cpu.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 99fd3f3..e534254 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1264,7 +1264,7 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features)
/* Features to be added */
uint32_t plus_features = 0, plus_ext_features = 0;
uint32_t plus_ext2_features = 0, plus_ext3_features = 0;
- uint32_t plus_kvm_features = kvm_default_features, plus_svm_features = 0;
+ uint32_t plus_kvm_features = 0, plus_svm_features = 0;
uint32_t plus_7_0_ebx_features = 0;
/* Features to be removed */
uint32_t minus_features = 0, minus_ext_features = 0;
@@ -1273,10 +1273,6 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features)
uint32_t minus_7_0_ebx_features = 0;
uint32_t numvalue;
- add_flagname_to_bitmaps("hypervisor", &plus_features,
- &plus_ext_features, &plus_ext2_features, &plus_ext3_features,
- &plus_kvm_features, &plus_svm_features, &plus_7_0_ebx_features);
-
featurestr = features ? strtok(features, ",") : NULL;
while (featurestr) {
@@ -1536,6 +1532,12 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
goto error;
}
+ def->kvm_features |= kvm_default_features;
+ add_flagname_to_bitmaps("hypervisor", &def->features,
+ &def->ext_features, &def->ext2_features,
+ &def->ext3_features, &def->kvm_features,
+ &def->svm_features, &def->cpuid_7_0_ebx_features);
+
if (cpu_x86_parse_featurestr(def, features) < 0) {
goto error;
}
--
1.7.1
next prev parent reply other threads:[~2012-12-11 10:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:11 [Qemu-devel] [PATCH 0/6] x86 CPU cleanup (wave 2) Igor Mammedov
2012-12-11 10:11 ` [Qemu-devel] [PATCH 1/6] target-i386: filter out not TCG features if running without kvm at realize time Igor Mammedov
2012-12-11 13:26 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features " Igor Mammedov
2012-12-11 13:31 ` Eduardo Habkost
2012-12-11 13:41 ` Igor Mammedov
2012-12-11 14:08 ` Igor Mammedov
2012-12-11 14:25 ` Eduardo Habkost
2012-12-11 14:18 ` [Qemu-devel] [PATCH 2/6 v3] " Igor Mammedov
2012-12-11 14:26 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 3/6] target-i386: explicitly set vendor for each built-in cpudef Igor Mammedov
2012-12-11 13:32 ` Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 4/6] target-i386: setting default 'vendor' is obsolete, remove it Igor Mammedov
2012-12-11 13:32 ` Eduardo Habkost
2012-12-11 10:11 ` Igor Mammedov [this message]
2012-12-11 13:33 ` [Qemu-devel] [PATCH 5/6] target-i386: move setting defaults out of cpu_x86_parse_featurestr() Eduardo Habkost
2012-12-11 10:11 ` [Qemu-devel] [PATCH 6/6] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-12-11 13:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355220666-31722-6-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=Don@CloudSwitch.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).