From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amos Kong <akong@redhat.com>, stefanha@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v2] net: clean up network at qemu process termination
Date: Tue, 11 Dec 2012 22:20:15 +0800 [thread overview]
Message-ID: <1355235615-30831-1-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1355233554-28130-1-git-send-email-akong@redhat.com>
We don't clean up network if fails to parse "-device" parameters without
calling net_cleanup(). I touch a problem, the tap device which is
created by qemu-ifup script could not be removed by qemu-ifdown script.
Some similar problems also exist in vl.c
In this patch, if network initialization successes, a cleanup function
will be registered to be called at qemu process termination.
Signed-off-by: Amos Kong <akong@redhat.com>
---
v2: register cleanup function before network initialization
---
vl.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index a3ab384..3bd773e 100644
--- a/vl.c
+++ b/vl.c
@@ -3745,6 +3745,9 @@ int main(int argc, char **argv, char **envp)
}
configure_icount(icount_option);
+ /* clean up network at qemu process termination */
+ atexit(&net_cleanup);
+
if (net_init_clients() < 0) {
exit(1);
}
@@ -3999,7 +4002,6 @@ int main(int argc, char **argv, char **envp)
main_loop();
bdrv_close_all();
pause_all_vcpus();
- net_cleanup();
res_free();
return 0;
--
1.7.1
next prev parent reply other threads:[~2012-12-11 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:45 [Qemu-devel] [PATCH] net: clean up network at qemu process termination Amos Kong
2012-12-11 14:03 ` Michael S. Tsirkin
2012-12-11 14:20 ` Amos Kong [this message]
2012-12-11 15:07 ` [Qemu-devel] [PATCH v2] " Michael S. Tsirkin
2012-12-18 13:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355235615-30831-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).