From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TinH3-0002U1-KC for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TinGy-00062R-9j for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:27:01 -0500 Received: from mail-ia0-f175.google.com ([209.85.210.175]:46524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TinGy-00062A-5Z for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:26:56 -0500 Received: by mail-ia0-f175.google.com with SMTP id z3so899602iad.6 for ; Wed, 12 Dec 2012 06:26:55 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 12 Dec 2012 15:26:36 +0100 Message-Id: <1355322396-32026-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1355322396-32026-1-git-send-email-pbonzini@redhat.com> References: <1355322396-32026-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] virtio-s390: reset all qbuses too when writing to the status field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: agraf@suse.de, mst@redhat.com virtio-s390 devices do not perform a full reset when zero is written to the status field. The reset does not propagate down the qdev bus hierarchy. Because of this, a virtio reset does not cancel in-flight I/O for virtio-scsi. Reported-by: Bryan Venteicher Cc: Alexander Graf Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index e0ac2d1..91d5a3a 100644 --- a/hw/s390-virtio-bus.c +++ b/hw/s390-virtio-bus.c @@ -309,8 +309,14 @@ void s390_virtio_device_update_status(VirtIOS390Device *dev) { VirtIODevice *vdev = dev->vdev; uint32_t features; + unsigned char status; - virtio_set_status(vdev, ldub_phys(dev->dev_offs + VIRTIO_DEV_OFFS_STATUS)); + status = ldub_phys(dev->dev_offs + VIRTIO_DEV_OFFS_STATUS); + if (status == 0) { + qdev_reset_all((DeviceState *)dev); + } + + virtio_set_status(vdev, status); /* Update guest supported feature bitmap */ -- 1.8.0.1