From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiwkQ-0006XD-DF for qemu-devel@nongnu.org; Wed, 12 Dec 2012 19:34:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiwkN-0005Lh-Vk for qemu-devel@nongnu.org; Wed, 12 Dec 2012 19:33:58 -0500 Date: Wed, 12 Dec 2012 18:33:40 -0600 From: Scott Wood References: <1355358059.28445.20@snotra> In-Reply-To: (from agraf@suse.de on Wed Dec 12 18:28:02 2012) Message-ID: <1355358820.28445.21@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org List" , qemu-devel qemu-devel On 12/12/2012 06:28:02 PM, Alexander Graf wrote: >=20 > On 13.12.2012, at 01:20, Scott Wood wrote: >=20 > > On 12/12/2012 06:04:11 PM, Alexander Graf wrote: > >> We could call bus->map_irq(...) with an artificially created =20 > PCIDevice struct ;). But that's pretty hacky. > > > > If we do anything like that, it should probably be to iterate over =20 > the devices that actually exist and add interrupt-map entries only =20 > for those. >=20 > Right. Though I'm not sure how pci hotplug slots would look like in =20 > that model. I don't think we have PCIDevice structs there yet, but we =20 > would still need to keep interrupt maps ready. Note that if we did limit it to only devices that actually exist, we'd =20 be producing a smaller interrupt-map than would be found on real =20 hardware for targets like mpc8544ds, if the slots aren't fully =20 populated. > >> So you're indicating you'd like the below patch? > > > > I think you pasted a bit more than one patch, but yes. >=20 > Yikes. It's way past midnight after all :). >=20 > You mean I messed up and pasted more than I wanted or that I should =20 > split the patch? :) The former. :-) > >> agraf@lychee:/home/agraf/release/qemu> git add hw/ppce500_pci.h > >> agraf@lychee:/home/agraf/release/qemu> git diff HEAD > >> agraf@lychee:/home/agraf/release/qemu> git diff HEAD | cat > > > > What does piping through cat get you? >=20 > Piping through cat gets me that I don't get the patch in less, so I =20 > can easily copy&paste it from my terminal into the email client even =20 > though it's bigger than my terminal window. Also not using less means =20 > that formatting stays consistent. Ah, forgot about git doing different things based on what stdout is. -Scott=