From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj6HK-0003t3-V5 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:44:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj6HK-0002lM-0G for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:44:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj6HJ-0002lA-OX for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:44:33 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDAiWes025623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Dec 2012 05:44:32 -0500 Message-ID: <1355395470.11795.0.camel@localhost> From: Pavel Hrdina Date: Thu, 13 Dec 2012 11:44:30 +0100 In-Reply-To: <50C9AB6D.8040004@redhat.com> References: <6a624c962a5e9dbd00271be1c5fd719d1dd338af.1355212056.git.phrdina@redhat.com> <50C9AB6D.8040004@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] atapi: reset cdrom tray statuses on ide_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, 2012-12-13 at 11:18 +0100, Kevin Wolf wrote: > Am 11.12.2012 08:55, schrieb Pavel Hrdina: > > Tray statuses should be also reseted. Some guests may lock the tray > > and after reset before any kernel is loaded the tray should be unlocked. > > > > Also if you reset the real computer the tray is closed. We should > > do the same in qemu. > > > > Signed-off-by: Pavel Hrdina > > Thanks, applied to the block branch. > > Do we need to reset more fields, like s->events? > > Kevin Good point, I'll check that. Pavel