From: Laszlo Ersek <lersek@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, lersek@redhat.com
Subject: [Qemu-devel] [PATCH] vmmouse_reset(): remove minimal code duplication
Date: Thu, 13 Dec 2012 15:01:49 +0100 [thread overview]
Message-ID: <1355407309-7138-1-git-send-email-lersek@redhat.com> (raw)
Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset().
vmmouse_disable() resets the status already.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
hw/vmmouse.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/vmmouse.c b/hw/vmmouse.c
index 6338efa..578122c 100644
--- a/hw/vmmouse.c
+++ b/hw/vmmouse.c
@@ -252,7 +252,6 @@ static void vmmouse_reset(DeviceState *d)
{
VMMouseState *s = container_of(d, VMMouseState, dev.qdev);
- s->status = 0xffff;
s->queue_size = VMMOUSE_QUEUE_SIZE;
vmmouse_disable(s);
--
1.7.1
next reply other threads:[~2012-12-13 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 14:01 Laszlo Ersek [this message]
2012-12-18 16:38 ` [Qemu-devel] [Qemu-trivial] [PATCH] vmmouse_reset(): remove minimal code duplication Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355407309-7138-1-git-send-email-lersek@redhat.com \
--to=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).