From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjUA9-0005Mc-8e for qemu-devel@nongnu.org; Fri, 14 Dec 2012 07:14:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjUA5-0000we-Qw for qemu-devel@nongnu.org; Fri, 14 Dec 2012 07:14:45 -0500 From: Alexander Graf Date: Fri, 14 Dec 2012 13:13:17 +0100 Message-Id: <1355487236-27451-2-git-send-email-agraf@suse.de> In-Reply-To: <1355487236-27451-1-git-send-email-agraf@suse.de> References: <1355487236-27451-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 01/40] pseries: Fix incorrect initialization of interrupt controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-ppc@nongnu.org List" Cc: qemu-devel qemu-devel , David Gibson From: David Gibson Currently in the reset code for the XICS interrupt controller, we initialize the pending_priority field to 0 (most favored, by XICS convention). This is incorrect, since there is no pending interrupt, it should be set to least favored - 0xff. At the moment our XICS implementation doesn't get hurt by this edge case, but it does confuse the upcoming kernel XICS implementation. Signed-off-by: David Gibson Signed-off-by: Alexander Graf --- hw/xics.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xics.c b/hw/xics.c index 1da3106..edf5833 100644 --- a/hw/xics.c +++ b/hw/xics.c @@ -495,7 +495,7 @@ static void xics_reset(void *opaque) for (i = 0; i < icp->nr_servers; i++) { icp->ss[i].xirr = 0; - icp->ss[i].pending_priority = 0; + icp->ss[i].pending_priority = 0xff; icp->ss[i].mfrr = 0xff; /* Make all outputs are deasserted */ qemu_set_irq(icp->ss[i].output, 0); -- 1.6.0.2