From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjVOd-0003im-Ef for qemu-devel@nongnu.org; Fri, 14 Dec 2012 08:33:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjVOb-0005HE-EY for qemu-devel@nongnu.org; Fri, 14 Dec 2012 08:33:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjVOb-0005Gx-7x for qemu-devel@nongnu.org; Fri, 14 Dec 2012 08:33:45 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEDXicO017324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Dec 2012 08:33:44 -0500 From: Hans de Goede Date: Fri, 14 Dec 2012 14:35:32 +0100 Message-Id: <1355492147-5023-12-git-send-email-hdegoede@redhat.com> In-Reply-To: <1355492147-5023-1-git-send-email-hdegoede@redhat.com> References: <1355492147-5023-1-git-send-email-hdegoede@redhat.com> Subject: [Qemu-devel] [PATCH 11/26] ehci: Don't call commit_irq after raising PCD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Hans de Goede , qemu-devel@nongnu.org ehci_raise_irq(s, USBSTS_PCD), gets applied immediately so there is no need to call commit_irq after it. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index c4d77bc..36165b0 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -757,7 +757,6 @@ static void ehci_attach(USBPort *port) *portsc |= PORTSC_CSC; ehci_raise_irq(s, USBSTS_PCD); - ehci_commit_irq(s); } static void ehci_detach(USBPort *port) @@ -787,7 +786,6 @@ static void ehci_detach(USBPort *port) *portsc |= PORTSC_CSC; ehci_raise_irq(s, USBSTS_PCD); - ehci_commit_irq(s); } static void ehci_child_detach(USBPort *port, USBDevice *child) -- 1.8.0.1