From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
khoa@us.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>
Subject: [Qemu-devel] [PATCH v7 01/12] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane
Date: Fri, 14 Dec 2012 19:00:34 +0100 [thread overview]
Message-ID: <1355508045-28120-2-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1355508045-28120-1-git-send-email-stefanha@redhat.com>
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the
file descriptor of a raw image file with Linux AIO enabled. This
interface is really a layering violation that can be resolved once the
block layer is able to run outside the global mutex - at that point
virtio-blk-data-plane will switch from custom Linux AIO code to using
the block layer.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block.h | 9 +++++++++
block/raw-posix.c | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+)
diff --git a/block.h b/block.h
index 893448a..c96f028 100644
--- a/block.h
+++ b/block.h
@@ -365,6 +365,15 @@ void bdrv_disable_copy_on_read(BlockDriverState *bs);
void bdrv_set_in_use(BlockDriverState *bs, int in_use);
int bdrv_in_use(BlockDriverState *bs);
+#ifdef CONFIG_LINUX_AIO
+int raw_get_aio_fd(BlockDriverState *bs);
+#else
+static inline int raw_get_aio_fd(BlockDriverState *bs)
+{
+ return -ENOTSUP;
+}
+#endif
+
enum BlockAcctType {
BDRV_ACCT_READ,
BDRV_ACCT_WRITE,
diff --git a/block/raw-posix.c b/block/raw-posix.c
index abfedbe..634824b 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1777,6 +1777,40 @@ static BlockDriver bdrv_host_cdrom = {
};
#endif /* __FreeBSD__ */
+#ifdef CONFIG_LINUX_AIO
+/**
+ * Return the file descriptor for Linux AIO
+ *
+ * This function is a layering violation and should be removed when it becomes
+ * possible to call the block layer outside the global mutex. It allows the
+ * caller to hijack the file descriptor so I/O can be performed outside the
+ * block layer.
+ */
+int raw_get_aio_fd(BlockDriverState *bs)
+{
+ BDRVRawState *s;
+
+ if (!bs->drv) {
+ return -ENOMEDIUM;
+ }
+
+ if (bs->drv == bdrv_find_format("raw")) {
+ bs = bs->file;
+ }
+
+ /* raw-posix has several protocols so just check for raw_aio_readv */
+ if (bs->drv->bdrv_aio_readv != raw_aio_readv) {
+ return -ENOTSUP;
+ }
+
+ s = bs->opaque;
+ if (!s->use_aio) {
+ return -ENOTSUP;
+ }
+ return s->fd;
+}
+#endif /* CONFIG_LINUX_AIO */
+
static void bdrv_file_init(void)
{
/*
--
1.8.0.2
next prev parent reply other threads:[~2012-12-14 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 18:00 [Qemu-devel] [PATCH v7 00/12] virtio: virtio-blk data plane Stefan Hajnoczi
2012-12-14 18:00 ` Stefan Hajnoczi [this message]
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 03/12] dataplane: add host memory mapping code Stefan Hajnoczi
2012-12-14 20:34 ` Blue Swirl
2012-12-17 9:10 ` Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 04/12] dataplane: add virtqueue vring code Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 05/12] dataplane: add event loop Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 06/12] dataplane: add Linux AIO request queue Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 07/12] iov: add iov_discard_front/back() to remove data Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 08/12] test-iov: add iov_discard_front/back() testcases Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 09/12] iov: add qemu_iovec_concat_iov() Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 10/12] virtio-blk: restore VirtIOBlkConf->config_wce flag Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 11/12] dataplane: add virtio-blk data plane code Stefan Hajnoczi
2012-12-14 18:00 ` [Qemu-devel] [PATCH v7 12/12] virtio-blk: add x-data-plane=on|off performance feature Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355508045-28120-2-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=asias@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=khoa@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).