From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjsR9-0008Qf-1L for qemu-devel@nongnu.org; Sat, 15 Dec 2012 09:09:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjsR6-0003Pj-KL for qemu-devel@nongnu.org; Sat, 15 Dec 2012 09:09:54 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:44091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjsR6-0003Pe-EB for qemu-devel@nongnu.org; Sat, 15 Dec 2012 09:09:52 -0500 From: Stefan Weil Date: Sat, 15 Dec 2012 15:09:31 +0100 Message-Id: <1355580573-19323-3-git-send-email-sw@weilnetz.de> In-Reply-To: <1355580573-19323-1-git-send-email-sw@weilnetz.de> References: <1355580573-19323-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH 2/4] block: Improve error report for wrong format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Kevin Wolf Cc: Stefan Weil , qemu-devel@nongnu.org There is no good system error for this kind of error, so it needs special handling instead of strerror. Signed-off-by: Stefan Weil --- blockdev.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5a4cd56..3da44f6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -624,8 +624,13 @@ DriveInfo *drive_init(QemuOpts *opts, BlockInterfaceType block_default_type) ret = bdrv_open(dinfo->bdrv, file, bdrv_flags, drv); if (ret < 0) { - error_report("could not open disk image %s: %s", - file, strerror(-ret)); + if (ret == BDRV_WRONG_FORMAT) { + error_report("could not open disk image %s: not in %s format", + file, drv->format_name); + } else { + error_report("could not open disk image %s: %s", + file, strerror(-ret)); + } goto err; } -- 1.7.10.4