qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Uri Lublin <uril@redhat.com>,
	qemu-stable@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 2/8] qxl+vnc: register a vm state change handler for dummy spice_server
Date: Mon, 17 Dec 2012 14:04:33 +0100	[thread overview]
Message-ID: <1355749479-25470-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1355749479-25470-1-git-send-email-kraxel@redhat.com>

From: Uri Lublin <uril@redhat.com>

When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.

Without it, from qxl_send_events(), the following error message is shown:
  qxl_send_events: spice-server bug: guest stopped, ignoring

Cc: qemu-stable@nongnu.org
Signed-off-by: Uri Lublin <uril@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/spice-core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 261c6f2..59ce5f6 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -732,6 +732,8 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
          */
         spice_server = spice_server_new();
         spice_server_init(spice_server, &core_interface);
+        qemu_add_vm_change_state_handler(vm_change_state_handler,
+                                         &spice_server);
     }
 
     return spice_server_add_interface(spice_server, sin);
-- 
1.7.1

  parent reply	other threads:[~2012-12-17 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 13:04 [Qemu-devel] [PULL 0/8] spice patch queue Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 1/8] qxl: save qemu_create_displaysurface_from result Gerd Hoffmann
2012-12-17 13:04 ` Gerd Hoffmann [this message]
2012-12-17 13:04 ` [Qemu-devel] [PATCH 3/8] spice-qemu-char: write to chardev whatever amount it can read Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 4/8] spice-qemu-char: factor out CharDriverState creation Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 5/8] spice-qemu-char: add spiceport chardev Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 6/8] spice-qemu-char: keep a list of spice chardev Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 7/8] spice-qemu-char: register spicevmc ports during qemu_spice_init() Gerd Hoffmann
2012-12-17 13:04 ` [Qemu-devel] [PATCH 8/8] docs: add spice-port-fqdn.txt Gerd Hoffmann
2012-12-18 23:49 ` [Qemu-devel] [PULL 0/8] spice patch queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355749479-25470-3-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=uril@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).