From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Don@CloudSwitch.com, ehabkost@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 13/20] target-i386: convert [cpuid_]vendor_override to bool
Date: Mon, 17 Dec 2012 17:01:25 +0100 [thread overview]
Message-ID: <1355760092-18755-14-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1355760092-18755-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
target-i386/cpu.c | 6 +++---
target-i386/cpu.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index ed67de7..2b7272a 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -284,7 +284,7 @@ typedef struct x86_def_t {
uint32_t kvm_features, svm_features;
uint32_t xlevel;
char model_id[48];
- int vendor_override;
+ bool vendor_override;
/* Store the results of Centaur's CPUID instructions */
uint32_t ext4_features;
uint32_t xlevel2;
@@ -859,7 +859,7 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_ECX);
cpu_x86_fill_model_id(x86_cpu_def->model_id);
- x86_cpu_def->vendor_override = 0;
+ x86_cpu_def->vendor_override = false;
/* Call Centaur's CPUID instruction. */
if (!strcmp(x86_cpu_def->vendor, CPUID_VENDOR_VIA)) {
@@ -1329,7 +1329,7 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features,
x86_cpu_def->xlevel = numvalue;
} else if (!strcmp(featurestr, "vendor")) {
pstrcpy(x86_cpu_def->vendor, sizeof(x86_cpu_def->vendor), val);
- x86_cpu_def->vendor_override = 1;
+ x86_cpu_def->vendor_override = true;
} else if (!strcmp(featurestr, "model_id")) {
pstrcpy(x86_cpu_def->model_id, sizeof(x86_cpu_def->model_id),
val);
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index fbbe730..0247253 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -812,7 +812,7 @@ typedef struct CPUX86State {
uint32_t cpuid_ext2_features;
uint32_t cpuid_ext3_features;
uint32_t cpuid_apic_id;
- int cpuid_vendor_override;
+ bool cpuid_vendor_override;
/* Store the results of Centaur's CPUID instructions */
uint32_t cpuid_xlevel2;
uint32_t cpuid_ext4_features;
--
1.7.1
next prev parent reply other threads:[~2012-12-17 16:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:01 [Qemu-devel] [PATCH 00/20 v2] x86 CPU cleanup (wave 2) Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 01/20] target-i386: filter out not TCG features if running without kvm at realize time Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's ext2_features " Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 03/20] target-i386: explicitly set vendor for each built-in cpudef Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 04/20] target-i386: setting default 'vendor' is obsolete, remove it Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 05/20] target-i386: move setting defaults out of cpu_x86_parse_featurestr() Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 06/20] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register() consolidate freeing resources Igor Mammedov
2012-12-18 15:28 ` Eduardo Habkost
2012-12-18 16:15 ` Igor Mammedov
2012-12-18 16:30 ` [Qemu-devel] [PATCH 07/20 v2] " Igor Mammedov
2012-12-19 16:36 ` Eduardo Habkost
2012-12-19 16:49 ` Igor Mammedov
2012-12-19 17:04 ` Eduardo Habkost
2012-12-19 17:18 ` Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 08/20] target-i386: compile kvm only functions if CONFIG_KVM is defined Igor Mammedov
2012-12-19 16:42 ` Eduardo Habkost
2012-12-19 17:16 ` Igor Mammedov
2012-12-20 17:03 ` Eduardo Habkost
2012-12-17 16:01 ` [Qemu-devel] [PATCH 09/20] target-i386: move kvm_check_features_against_host() check to realize time Igor Mammedov
2012-12-19 16:49 ` Eduardo Habkost
2012-12-17 16:01 ` [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs Igor Mammedov
2012-12-19 16:54 ` Eduardo Habkost
2012-12-19 20:18 ` Igor Mammedov
2012-12-20 14:10 ` Eduardo Habkost
2012-12-20 20:22 ` Igor Mammedov
2012-12-20 22:13 ` Eduardo Habkost
2012-12-21 0:56 ` Igor Mammedov
2012-12-21 13:50 ` Eduardo Habkost
2012-12-27 14:33 ` Igor Mammedov
2012-12-27 14:47 ` Eduardo Habkost
2012-12-17 16:01 ` [Qemu-devel] [PATCH 11/20] target-i386: do not set vendor_override in x86_cpuid_set_vendor() Igor Mammedov
2012-12-19 17:38 ` Eduardo Habkost
2012-12-19 19:13 ` Andreas Färber
2012-12-19 22:47 ` Igor Mammedov
2012-12-20 12:47 ` Eduardo Habkost
2012-12-20 0:02 ` [Qemu-devel] target-i386: Remove *vendor_override fields from x86_def_t and CPUX86State Igor Mammedov
2012-12-20 0:16 ` [Qemu-devel] [PATCH 11/20] target-i386: add x86cpu_vendor_words2str() Igor Mammedov
2012-12-20 19:54 ` Eduardo Habkost
2012-12-20 0:16 ` [Qemu-devel] [PATCH 12/20 v2] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2012-12-20 19:59 ` Eduardo Habkost
2012-12-20 0:16 ` [Qemu-devel] [PATCH 13/20] target-i386: remove vendor_override field from CPUX86State Igor Mammedov
2012-12-20 12:48 ` Eduardo Habkost
2012-12-20 12:56 ` Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 12/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2012-12-17 16:01 ` Igor Mammedov [this message]
2012-12-17 16:01 ` [Qemu-devel] [PATCH 14/20] target-i386: set custom 'vendor' without intermediate x86_def_t Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' " Igor Mammedov
2012-12-19 17:58 ` Eduardo Habkost
2012-12-19 20:45 ` Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' " Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 17/20] target-i386: set custom 'model-id' " Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 18/20] target-i386: set custom 'stepping' " Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 19/20] target-i386: set custom 'model' " Igor Mammedov
2012-12-17 16:01 ` [Qemu-devel] [PATCH 20/20] target-i386: set custom 'family' " Igor Mammedov
2012-12-17 20:43 ` [Qemu-devel] [PATCH 00/20 v2] x86 CPU cleanup (wave 2) Andreas Färber
2012-12-17 21:34 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355760092-18755-14-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=Don@CloudSwitch.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).