qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, Alexander Graf <agraf@suse.de>, mst@redhat.com
Subject: [Qemu-devel] [PATCH 14/15] virtio-s390: reset all qbuses too when writing to the status field
Date: Mon, 17 Dec 2012 17:24:49 +0100	[thread overview]
Message-ID: <1355761490-10073-15-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1355761490-10073-1-git-send-email-pbonzini@redhat.com>

virtio-s390 devices do not perform a reset when zero is written to the
status byte.  Because of this, a virtio reset does not cancel in-flight
I/O for virtio-scsi.

Use qdev_reset_all so that the reset correctly propagates down the qdev
bus hierarchy.

Reported-by: Bryan Venteicher <bryanv@daemoninthecloset.org>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/s390-virtio-bus.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index 34173a7..b8465d1 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -309,8 +309,14 @@ void s390_virtio_device_update_status(VirtIOS390Device *dev)
 {
     VirtIODevice *vdev = dev->vdev;
     uint32_t features;
+    unsigned char status;
 
-    virtio_set_status(vdev, ldub_phys(dev->dev_offs + VIRTIO_DEV_OFFS_STATUS));
+    status = ldub_phys(dev->dev_offs + VIRTIO_DEV_OFFS_STATUS);
+    if (status == 0) {
+        qdev_reset_all((DeviceState *)dev);
+    }
+
+    virtio_set_status(vdev, status);
 
     /* Update guest supported feature bitmap */
 
-- 
1.8.0.2

  parent reply	other threads:[~2012-12-17 16:25 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 16:24 [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 01/15] qdev: do not reset a device until the parent has been initialized Paolo Bonzini
2012-12-17 16:52   ` Michael S. Tsirkin
2012-12-17 16:53     ` Michael S. Tsirkin
2012-12-17 17:06       ` Paolo Bonzini
2012-12-17 21:57   ` Andreas Färber
2012-12-17 16:24 ` [Qemu-devel] [PATCH 02/15] intel-hda: do not reset codecs from intel_hda_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 03/15] pci: clean up resetting of IRQs Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 04/15] virtio-pci: reset device before PCI layer Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 05/15] virtio-s390: add a reset function to virtio-s390 devices Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 06/15] qdev: add qbus_reset_all Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 07/15] pci: do not export pci_bus_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 08/15] lsi: use qbus_reset_all to reset SCSI bus Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 09/15] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 10/15] qdev: switch reset to post-order Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 11/15] qdev: remove device_reset Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 12/15] qdev: document reset semantics Paolo Bonzini
2012-12-17 16:24 ` [Qemu-devel] [PATCH 13/15] virtio-pci: reset all qbuses too when writing to the status field Paolo Bonzini
2012-12-17 16:48   ` Michael S. Tsirkin
2012-12-17 16:54     ` Paolo Bonzini
2012-12-17 17:08       ` Michael S. Tsirkin
2012-12-17 17:09         ` Paolo Bonzini
2012-12-17 16:24 ` Paolo Bonzini [this message]
2012-12-17 16:29   ` [Qemu-devel] [PATCH 14/15] virtio-s390: " Alexander Graf
2012-12-17 16:24 ` [Qemu-devel] [PATCH 15/15] virtio-serial: do not perform bus reset by hand Paolo Bonzini
2012-12-17 21:43 ` [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices Michael S. Tsirkin
2012-12-18  7:27   ` Paolo Bonzini
2012-12-18  8:35     ` Paolo Bonzini
2012-12-18  9:49       ` Michael S. Tsirkin
2012-12-18 11:40         ` Paolo Bonzini
2013-01-07 17:46           ` Michael S. Tsirkin
2013-01-07 19:10 ` Anthony Liguori
2013-01-07 19:57   ` Peter Maydell
2013-01-07 20:20     ` Anthony Liguori
2013-01-07 20:28       ` Peter Maydell
2013-01-07 20:51         ` Anthony Liguori
2013-01-09  9:33   ` Paolo Bonzini
2013-01-09 10:22     ` Michael S. Tsirkin
2013-01-09 10:53       ` Paolo Bonzini
2013-01-09 11:09         ` Michael S. Tsirkin
2013-01-09 11:12           ` Paolo Bonzini
2013-01-09 12:10             ` Michael S. Tsirkin
2013-01-09 17:46               ` Paolo Bonzini
2013-01-09 20:40                 ` Anthony Liguori
2013-01-09 21:22                   ` Paolo Bonzini
2013-01-09 21:40                     ` Michael S. Tsirkin
2013-01-10  8:31                       ` Paolo Bonzini
2013-01-10 11:32                         ` Michael S. Tsirkin
2013-01-10 11:46     ` Peter Maydell
2013-01-10 11:47       ` Paolo Bonzini
2013-01-10 11:59         ` Peter Maydell
2013-01-10 12:12           ` Paolo Bonzini
2013-01-10 12:31             ` Peter Maydell
2013-01-10 12:45               ` Paolo Bonzini
2013-01-10 13:01                 ` Peter Maydell
2013-01-10 13:32                   ` Paolo Bonzini
2013-01-10 14:14               ` Anthony Liguori
2013-01-10 14:38                 ` Paolo Bonzini
2013-01-10 15:01                 ` Michael S. Tsirkin
2013-01-08 13:58 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355761490-10073-15-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).