From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "open list:Overall" <kvm@vger.kernel.org>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
"Avi Kivity" <avi@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR
Date: Tue, 18 Dec 2012 08:53:43 +0100 [thread overview]
Message-ID: <1355817223-13076-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1355817223-13076-1-git-send-email-afaerber@suse.de>
Previously we silently exited, with subclasses we got an opcode warning.
Instead explicitly tell the user what's wrong.
An indication for this is -cpu ? showing "host" with an all-zero PVR.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
target-ppc/kvm.c | 7 +++++++
1 Datei geändert, 7 Zeilen hinzugefügt(+)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index f115892..8998d0f 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1186,7 +1186,14 @@ static void alter_insns(uint64_t *word, uint64_t flags, bool on)
static void kvmppc_host_cpu_initfn(Object *obj)
{
+ PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(obj);
+
assert(kvm_enabled());
+
+ if (pcc->info->pvr != mfpvr()) {
+ fprintf(stderr, "Host PVR unsupported.\n");
+ exit(1);
+ }
}
static void kvmppc_host_cpu_class_init(ObjectClass *oc, void *data)
--
1.7.10.4
next prev parent reply other threads:[~2012-12-18 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 7:53 [Qemu-devel] [PATCH qom-cpu 0/4] CPU cleanup and PPC subclasses Andreas Färber
2012-12-18 7:53 ` [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct Andreas Färber
2012-12-18 15:59 ` Igor Mammedov
2012-12-18 18:44 ` Andreas Färber
2012-12-18 17:42 ` Eduardo Habkost
2012-12-18 20:00 ` Andreas Färber
2012-12-18 7:53 ` [Qemu-devel] [PATCH RFC qom-cpu 2/4] qemu-common.h: Move fprintf_function to qemu-types.h Andreas Färber
2012-12-18 17:25 ` Eduardo Habkost
2012-12-18 7:53 ` [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of model definitions to QOM subclasses Andreas Färber
2012-12-18 18:15 ` Eduardo Habkost
2012-12-19 2:46 ` Andreas Färber
2012-12-18 7:53 ` Andreas Färber [this message]
2013-01-03 12:26 ` [Qemu-devel] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355817223-13076-5-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).