From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tks08-0003MD-QX for qemu-devel@nongnu.org; Tue, 18 Dec 2012 02:54:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tks06-0002hU-BX for qemu-devel@nongnu.org; Tue, 18 Dec 2012 02:54:08 -0500 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Tue, 18 Dec 2012 08:53:43 +0100 Message-Id: <1355817223-13076-5-git-send-email-afaerber@suse.de> In-Reply-To: <1355817223-13076-1-git-send-email-afaerber@suse.de> References: <1355817223-13076-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "open list:Overall" , Marcelo Tosatti , Alexander Graf , "open list:PowerPC" , Avi Kivity , =?UTF-8?q?Andreas=20F=C3=A4rber?= , David Gibson Previously we silently exited, with subclasses we got an opcode warning. Instead explicitly tell the user what's wrong. An indication for this is -cpu ? showing "host" with an all-zero PVR. Signed-off-by: Andreas F=C3=A4rber --- target-ppc/kvm.c | 7 +++++++ 1 Datei ge=C3=A4ndert, 7 Zeilen hinzugef=C3=BCgt(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index f115892..8998d0f 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1186,7 +1186,14 @@ static void alter_insns(uint64_t *word, uint64_t f= lags, bool on) =20 static void kvmppc_host_cpu_initfn(Object *obj) { + PowerPCCPUClass *pcc =3D POWERPC_CPU_GET_CLASS(obj); + assert(kvm_enabled()); + + if (pcc->info->pvr !=3D mfpvr()) { + fprintf(stderr, "Host PVR unsupported.\n"); + exit(1); + } } =20 static void kvmppc_host_cpu_class_init(ObjectClass *oc, void *data) --=20 1.7.10.4