From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 02/10] pflash_cfi01: qemu_log_mask "unimplemented" msg
Date: Tue, 18 Dec 2012 17:51:09 +0100 [thread overview]
Message-ID: <1355849477-1226-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1355849477-1226-1-git-send-email-stefanha@redhat.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
This printf is informing the user of unimplemented functionality. It should be
re-directed to qemu_log(LOG_UNIMP, ...) accordingly.
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/pflash_cfi01.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 7d040b5..f9f8e5d 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -438,9 +438,9 @@ static void pflash_write(pflash_t *pfl, hwaddr offset,
return;
error_flash:
- printf("%s: Unimplemented flash cmd sequence "
- "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n",
- __func__, offset, pfl->wcycle, pfl->cmd, value);
+ qemu_log_mask(LOG_UNIMP, "%s: Unimplemented flash cmd sequence "
+ "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)"
+ "\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
reset_flash:
memory_region_rom_device_set_readable(&pfl->mem, true);
--
1.8.0.2
next prev parent reply other threads:[~2012-12-18 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:51 [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012 Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 01/10] net, hub: fix the indent in the comments Stefan Hajnoczi
2012-12-18 16:51 ` Stefan Hajnoczi [this message]
2012-12-18 16:51 ` [Qemu-devel] [PATCH 03/10] pflash_cfi0x: Send debug messages to stderr Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 04/10] zynq_slcr: Compile time warning fixes Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 05/10] arm_gic: Add cpu nr to Raised IRQ message Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 06/10] gitignore: Add virtfs-proxy-helper Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups() Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication Stefan Hajnoczi
2012-12-18 16:51 ` [Qemu-devel] [PATCH 10/10] configure: Earlier pkg-config probe Stefan Hajnoczi
2012-12-18 23:49 ` [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355849477-1226-3-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).