From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0OK-0002T6-ME for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl0OH-0005S0-OU for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0OH-0005Rs-H5 for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:37 -0500 From: Stefan Hajnoczi Date: Tue, 18 Dec 2012 17:51:15 +0100 Message-Id: <1355849477-1226-9-git-send-email-stefanha@redhat.com> In-Reply-To: <1355849477-1226-1-git-send-email-stefanha@redhat.com> References: <1355849477-1226-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori From: John Spencer this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header. Signed-off-by: John Spencer Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 31d5276..275260a 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -584,7 +585,6 @@ extern int personality(int); extern int flock(int, int); extern int setfsuid(int); extern int setfsgid(int); -extern int setgroups(int, gid_t *); /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM -- 1.8.0.2