From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Uri Lublin <uril@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
Date: Wed, 19 Dec 2012 14:07:16 +0100 [thread overview]
Message-ID: <1355922436-8378-1-git-send-email-stefanha@redhat.com> (raw)
The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.
The vm change state handler is added with a pointer to the spice_server
pointer. This is useless and we probably would not want 2 levels of
pointers.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
ui/spice-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index ac46deb..c128c0b 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -709,7 +709,7 @@ void qemu_spice_init(void)
qemu_spice_input_init();
qemu_spice_audio_init();
- qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
g_free(x509_key_file);
g_free(x509_cert_file);
@@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
- qemu_add_vm_change_state_handler(vm_change_state_handler,
- &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
}
return spice_server_add_interface(spice_server, sin);
--
1.8.0.2
next reply other threads:[~2012-12-19 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:07 Stefan Hajnoczi [this message]
2012-12-19 15:39 ` [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Uri Lublin
2013-01-02 15:56 ` Stefan Hajnoczi
2013-01-03 8:20 ` Gerd Hoffmann
2013-01-03 10:57 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355922436-8378-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).