* [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
@ 2012-12-19 13:07 Stefan Hajnoczi
2012-12-19 15:39 ` Uri Lublin
2013-01-02 15:56 ` Stefan Hajnoczi
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-12-19 13:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Uri Lublin, Gerd Hoffmann
The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.
The vm change state handler is added with a pointer to the spice_server
pointer. This is useless and we probably would not want 2 levels of
pointers.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
ui/spice-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index ac46deb..c128c0b 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -709,7 +709,7 @@ void qemu_spice_init(void)
qemu_spice_input_init();
qemu_spice_audio_init();
- qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
g_free(x509_key_file);
g_free(x509_cert_file);
@@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
- qemu_add_vm_change_state_handler(vm_change_state_handler,
- &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
}
return spice_server_add_interface(spice_server, sin);
--
1.8.0.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
2012-12-19 13:07 [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Stefan Hajnoczi
@ 2012-12-19 15:39 ` Uri Lublin
2013-01-02 15:56 ` Stefan Hajnoczi
1 sibling, 0 replies; 5+ messages in thread
From: Uri Lublin @ 2012-12-19 15:39 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Anthony Liguori, qemu-devel, Gerd Hoffmann
On 12/19/2012 03:07 PM, Stefan Hajnoczi wrote:
> The spice_server pointer is a global variable and
... is a static variable in ui/spice-core.c and
> vm_change_state_handler() therefore does not use its opaque parameter.
>
> The vm change state handler is added with a pointer to the spice_server
> pointer. This is useless and we probably would not want 2 levels of
> pointers.
Reviewed-by: Uri Lublin <uril@redhat.com>
>
> Signed-off-by: Stefan Hajnoczi<stefanha@redhat.com>
> ---
> ui/spice-core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index ac46deb..c128c0b 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -709,7 +709,7 @@ void qemu_spice_init(void)
> qemu_spice_input_init();
> qemu_spice_audio_init();
>
> - qemu_add_vm_change_state_handler(vm_change_state_handler,&spice_server);
> + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
>
> g_free(x509_key_file);
> g_free(x509_cert_file);
> @@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
> */
> spice_server = spice_server_new();
> spice_server_init(spice_server,&core_interface);
> - qemu_add_vm_change_state_handler(vm_change_state_handler,
> -&spice_server);
> + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
> }
>
> return spice_server_add_interface(spice_server, sin);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
2012-12-19 13:07 [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Stefan Hajnoczi
2012-12-19 15:39 ` Uri Lublin
@ 2013-01-02 15:56 ` Stefan Hajnoczi
2013-01-03 8:20 ` Gerd Hoffmann
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2013-01-02 15:56 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Anthony Liguori, Uri Lublin, qemu-devel
On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
> The spice_server pointer is a global variable and
> vm_change_state_handler() therefore does not use its opaque parameter.
>
> The vm change state handler is added with a pointer to the spice_server
> pointer. This is useless and we probably would not want 2 levels of
> pointers.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> ui/spice-core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index ac46deb..c128c0b 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -709,7 +709,7 @@ void qemu_spice_init(void)
> qemu_spice_input_init();
> qemu_spice_audio_init();
>
> - qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
> + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
>
> g_free(x509_key_file);
> g_free(x509_cert_file);
> @@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
> */
> spice_server = spice_server_new();
> spice_server_init(spice_server, &core_interface);
> - qemu_add_vm_change_state_handler(vm_change_state_handler,
> - &spice_server);
> + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
> }
>
> return spice_server_add_interface(spice_server, sin);
> --
> 1.8.0.2
Gerd, would you like to take this through the spice queue or should I
put it in trivial-patches?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
2013-01-02 15:56 ` Stefan Hajnoczi
@ 2013-01-03 8:20 ` Gerd Hoffmann
2013-01-03 10:57 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2013-01-03 8:20 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Anthony Liguori, Uri Lublin, qemu-devel
On 01/02/13 16:56, Stefan Hajnoczi wrote:
> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
>> The spice_server pointer is a global variable and
>> vm_change_state_handler() therefore does not use its opaque parameter.
>>
>> The vm change state handler is added with a pointer to the spice_server
>> pointer. This is useless and we probably would not want 2 levels of
>> pointers.
> Gerd, would you like to take this through the spice queue or should I
> put it in trivial-patches?
Taking through trivial is fine with me, especially as the spice patch
queue is empty atm ;)
thanks,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
2013-01-03 8:20 ` Gerd Hoffmann
@ 2013-01-03 10:57 ` Stefan Hajnoczi
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2013-01-03 10:57 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Anthony Liguori, Uri Lublin, qemu-devel
On Thu, Jan 3, 2013 at 9:20 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On 01/02/13 16:56, Stefan Hajnoczi wrote:
>> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
>>> The spice_server pointer is a global variable and
>>> vm_change_state_handler() therefore does not use its opaque parameter.
>>>
>>> The vm change state handler is added with a pointer to the spice_server
>>> pointer. This is useless and we probably would not want 2 levels of
>>> pointers.
>
>> Gerd, would you like to take this through the spice queue or should I
>> put it in trivial-patches?
>
> Taking through trivial is fine with me, especially as the spice patch
> queue is empty atm ;)
Okay, I'll take it. Thanks!
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-03 10:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-19 13:07 [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Stefan Hajnoczi
2012-12-19 15:39 ` Uri Lublin
2013-01-02 15:56 ` Stefan Hajnoczi
2013-01-03 8:20 ` Gerd Hoffmann
2013-01-03 10:57 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).