From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlLcE-0005Fq-NW for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:31:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlLcD-0000b6-GR for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:31:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36754 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlLcD-0000b0-Ag for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:31:25 -0500 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 19 Dec 2012 16:31:06 +0100 Message-Id: <1355931071-22100-3-git-send-email-afaerber@suse.de> In-Reply-To: <1355931071-22100-1-git-send-email-afaerber@suse.de> References: <1355931071-22100-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , Aurelien Jarno This function will be touched again soon, so a good understanding of env vs. other helps. Adopt gtk-doc style. Signed-off-by: Andreas F=C3=A4rber --- target-mips/op_helper.c | 14 +++++++++----- 1 Datei ge=C3=A4ndert, 9 Zeilen hinzugef=C3=BCgt(+), 5 Zeilen entfernt(-= ) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index f9f2b23..83998ab 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helper.c @@ -573,11 +573,15 @@ static inline void mips_tc_sleep(MIPSCPU *cpu, int = tc) } } =20 -/* tc should point to an int with the value of the global TC index. - This function will transform it into a local index within the - returned CPUMIPSState. - - FIXME: This code assumes that all VPEs have the same number of TCs, +/** + * mips_cpu_map_tc: + * @env: CPU from which mapping is performed. + * @tc: Should point to an int with the value of the global TC index. + * + * This function will transform @tc into a local index within the + * returned #CPUMIPSState. + */ +/* FIXME: This code assumes that all VPEs have the same number of TCs, which depends on runtime setup. Can probably be fixed by walking the list of CPUMIPSStates. */ static CPUMIPSState *mips_cpu_map_tc(CPUMIPSState *env, int *tc) --=20 1.7.10.4