From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlM3B-0000Gu-Qa for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:59:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlM38-00081C-8w for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:59:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlM38-00080q-1U for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:59:14 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBJFxDCY010305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Dec 2012 10:59:13 -0500 From: Gerd Hoffmann Date: Wed, 19 Dec 2012 16:59:07 +0100 Message-Id: <1355932747-1755-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1355932747-1755-1-git-send-email-kraxel@redhat.com> References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 9/9] chardev: hotplug, qmp, parallel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Gerd Hoffmann , mprivozn@redhat.com Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 3 ++- qemu-char.c | 43 +++++++++++++++++++++++++++---------------- 2 files changed, 29 insertions(+), 17 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index d833385..0922823 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3037,7 +3037,8 @@ 'out' : 'ChardevFileSource' } } { 'enum': 'ChardevPortKind', 'data': [ 'tty', - 'serial' ] } + 'serial', + 'parport' ] } { 'type': 'ChardevPort', 'data': { 'device' : 'ChardevFileSource', 'type' : 'ChardevPortKind'} } diff --git a/qemu-char.c b/qemu-char.c index 9f23c25..5dedacc 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1357,17 +1357,10 @@ static void pp_close(CharDriverState *chr) qemu_chr_be_event(chr, CHR_EVENT_CLOSED); } -static CharDriverState *qemu_chr_open_pp(QemuOpts *opts) +static CharDriverState *qemu_chr_open_pp_fd(int fd) { - const char *filename = qemu_opt_get(opts, "path"); CharDriverState *chr; ParallelCharDriver *drv; - int fd; - - TFR(fd = qemu_open(filename, O_RDWR)); - if (fd < 0) { - return NULL; - } if (ioctl(fd, PPCLAIM) < 0) { close(fd); @@ -1431,16 +1424,9 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg) return 0; } -static CharDriverState *qemu_chr_open_pp(QemuOpts *opts) +static CharDriverState *qemu_chr_open_pp_fd(int fd) { - const char *filename = qemu_opt_get(opts, "path"); CharDriverState *chr; - int fd; - - fd = qemu_open(filename, O_RDWR); - if (fd < 0) { - return NULL; - } chr = g_malloc0(sizeof(CharDriverState)); chr->opaque = (void *)(intptr_t)fd; @@ -2740,6 +2726,22 @@ fail: return NULL; } +#ifdef HAVE_CHARDEV_PARPORT + +static CharDriverState *qemu_chr_open_pp(QemuOpts *opts) +{ + const char *filename = qemu_opt_get(opts, "path"); + int fd; + + fd = qemu_open(filename, O_RDWR); + if (fd < 0) { + return NULL; + } + return qemu_chr_open_pp_fd(fd); +} + +#endif + static const struct { const char *name; CharDriverState *(*open)(QemuOpts *opts); @@ -3039,6 +3041,15 @@ static CharDriverState *qmp_chardev_open_port(ChardevPort *port, Error **errp) } return qemu_chr_open_tty_fd(fd); #endif +#ifdef HAVE_CHARDEV_PARPORT + case CHARDEV_PORT_KIND_PARPORT: + flags = O_RDWR; + fd = qmp_chardev_open_file_source(port->device, flags, errp); + if (error_is_set(errp)) { + return NULL; + } + return qemu_chr_open_pp_fd(fd); +#endif default: error_setg(errp, "unknown chardev port (%d)", port->type); return NULL; -- 1.7.1