From: Avik Sil <aviksil@linux.vnet.ibm.com>
To: aliguori@us.ibm.com, agraf@suse.de
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PATCH v3 2/2] pseries: set no default boot order
Date: Wed, 19 Dec 2012 23:46:42 +0530 [thread overview]
Message-ID: <1355941002-12483-3-git-send-email-aviksil@linux.vnet.ibm.com> (raw)
In-Reply-To: <1355941002-12483-1-git-send-email-aviksil@linux.vnet.ibm.com>
This patch removes the default boot order for pseries machine. This allows
the machine to handle a NULL boot order in case no -boot option is provided.
Thus it helps SLOF firmware to verify if boot order is specified in command
line or not. If no boot order is provided SLOF tries to boot from the
device set in the nvram.
Signed-off-by: Avik Sil <aviksil@linux.vnet.ibm.com>
---
hw/spapr.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/spapr.c b/hw/spapr.c
index a4a65c7..abfa0d9 100644
--- a/hw/spapr.c
+++ b/hw/spapr.c
@@ -284,7 +284,9 @@ static void *spapr_create_fdt_skel(const char *cpu_model,
_FDT((fdt_property(fdt, "qemu,boot-kernel", &kprop, sizeof(kprop))));
}
- _FDT((fdt_property_string(fdt, "qemu,boot-device", boot_device)));
+ if (boot_device) {
+ _FDT((fdt_property_string(fdt, "qemu,boot-device", boot_device)));
+ }
_FDT((fdt_property_cell(fdt, "qemu,graphic-width", graphic_width)));
_FDT((fdt_property_cell(fdt, "qemu,graphic-height", graphic_height)));
_FDT((fdt_property_cell(fdt, "qemu,graphic-depth", graphic_depth)));
@@ -960,7 +962,7 @@ static QEMUMachine spapr_machine = {
.block_default_type = IF_SCSI,
.max_cpus = MAX_CPUS,
.no_parallel = 1,
- DEFAULT_MACHINE_OPTIONS,
+ .boot_order = NULL,
};
static void spapr_machine_init(void)
--
1.7.11.7
next prev parent reply other threads:[~2012-12-19 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 18:16 [Qemu-devel] [PATCH v3 0/2] Qemu boot order patch series Avik Sil
2012-12-19 18:16 ` [Qemu-devel] [PATCH v3 1/2] Make default boot order machine specific Avik Sil
2012-12-19 18:16 ` Avik Sil [this message]
2012-12-19 22:34 ` [Qemu-devel] [PATCH v3 0/2] Qemu boot order patch series Alexander Graf
2013-01-07 20:22 ` Anthony Liguori
2013-01-07 21:04 ` Alexander Graf
2013-01-07 21:19 ` Anthony Liguori
2013-01-16 1:43 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355941002-12483-3-git-send-email-aviksil@linux.vnet.ibm.com \
--to=aviksil@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).