qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 07/15] openpic: make ctpr signed
Date: Fri, 21 Dec 2012 20:15:44 -0600	[thread overview]
Message-ID: <1356142552-13453-8-git-send-email-scottwood@freescale.com> (raw)
In-Reply-To: <1356142552-13453-1-git-send-email-scottwood@freescale.com>

Other priorities are signed, so avoid comparisons between
signed and unsigned.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 hw/openpic.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/openpic.c b/hw/openpic.c
index 94a7807..9d22e9c 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -216,7 +216,7 @@ typedef struct IRQ_src_t {
 #define IDR_CI      0x40000000  /* critical interrupt */
 
 typedef struct IRQ_dst_t {
-    uint32_t ctpr; /* CPU current task priority */
+    int32_t ctpr; /* CPU current task priority */
     IRQ_queue_t raised;
     IRQ_queue_t servicing;
     qemu_irq *irqs;
@@ -1170,7 +1170,7 @@ static void openpic_save(QEMUFile* f, void *opaque)
     qemu_put_be32s(f, &opp->nb_cpus);
 
     for (i = 0; i < opp->nb_cpus; i++) {
-        qemu_put_be32s(f, &opp->dst[i].ctpr);
+        qemu_put_sbe32s(f, &opp->dst[i].ctpr);
         openpic_save_IRQ_queue(f, &opp->dst[i].raised);
         openpic_save_IRQ_queue(f, &opp->dst[i].servicing);
     }
@@ -1216,7 +1216,7 @@ static int openpic_load(QEMUFile* f, void *opaque, int version_id)
     qemu_get_be32s(f, &opp->nb_cpus);
 
     for (i = 0; i < opp->nb_cpus; i++) {
-        qemu_get_be32s(f, &opp->dst[i].ctpr);
+        qemu_get_sbe32s(f, &opp->dst[i].ctpr);
         openpic_load_IRQ_queue(f, &opp->dst[i].raised);
         openpic_load_IRQ_queue(f, &opp->dst[i].servicing);
     }
-- 
1.7.9.5

  parent reply	other threads:[~2012-12-22  2:16 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22  2:15 [Qemu-devel] [PATCH 00/15] openpic: cleanups and fixes Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 01/15] openpic: fix debug prints Scott Wood
2013-01-03 17:31   ` Alexander Graf
2013-01-03 19:41     ` Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 02/15] openpic: lower interrupt when reading the MSI register Scott Wood
2013-01-03 17:52   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 03/15] openpic: fix sense and priority bits Scott Wood
2013-01-03 17:51   ` Alexander Graf
2013-01-03 20:12     ` Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 04/15] ppc/booke: fix crit/mcheck/debug exceptions Scott Wood
2013-01-03 17:57   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 05/15] openpic: make register names correspond better with hw docs Scott Wood
2013-01-03 18:18   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 06/15] openpic: rework critical interrupt support Scott Wood
2013-01-03 18:31   ` Alexander Graf
2013-01-03 23:07     ` Scott Wood
2013-01-04  8:04       ` Alexander Graf
2013-01-04 20:46       ` [Qemu-devel] [Qemu-ppc] " Blue Swirl
2013-01-04 20:49         ` Scott Wood
2013-01-04 21:17           ` Blue Swirl
2013-01-04 21:25             ` Scott Wood
2012-12-22  2:15 ` Scott Wood [this message]
2013-01-03 18:33   ` [Qemu-devel] [PATCH 07/15] openpic: make ctpr signed Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 08/15] openpic/fsl: critical interrupts ignore mask before v4.1 Scott Wood
2013-01-03 18:37   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 09/15] openpic: always call IRQ_check from IRQ_get_next Scott Wood
2013-01-03 18:42   ` Alexander Graf
2013-01-03 20:09     ` Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 10/15] Revert "openpic: Accelerate pending irq search" Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 11/15] openpic: use standard bitmap operations Scott Wood
2013-01-03 18:49   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 12/15] openpic: IRQ_check: search the queue a word at a time Scott Wood
2013-01-03 18:53   ` Alexander Graf
2013-01-03 20:07     ` Scott Wood
2013-01-03 20:31       ` Alexander Graf
2013-01-03 20:32         ` Scott Wood
2013-01-03 20:57           ` Alexander Graf
2013-01-03 21:52             ` Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 13/15] openpic: add some bounds checking for IRQ numbers Scott Wood
2013-01-03 18:55   ` Alexander Graf
2013-01-03 19:54     ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2013-01-03 21:07       ` Alexander Graf
2013-01-03 21:20         ` Scott Wood
2012-12-22  2:15 ` [Qemu-devel] [PATCH 14/15] openpic: move IACK to its own function Scott Wood
2013-01-03 18:59   ` Alexander Graf
2012-12-22  2:15 ` [Qemu-devel] [PATCH 15/15] openpic: fix CTPR and de-assertion of interrupts Scott Wood
2013-01-03 19:00   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356142552-13453-8-git-send-email-scottwood@freescale.com \
    --to=scottwood@freescale.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).