From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmEdS-0000F8-PA for qemu-devel@nongnu.org; Fri, 21 Dec 2012 21:16:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TmEdL-0006DE-LI for qemu-devel@nongnu.org; Fri, 21 Dec 2012 21:16:22 -0500 From: Scott Wood Date: Fri, 21 Dec 2012 20:15:44 -0600 Message-ID: <1356142552-13453-8-git-send-email-scottwood@freescale.com> In-Reply-To: <1356142552-13453-1-git-send-email-scottwood@freescale.com> References: <1356142552-13453-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 07/15] openpic: make ctpr signed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Scott Wood , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Other priorities are signed, so avoid comparisons between signed and unsigned. Signed-off-by: Scott Wood --- hw/openpic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 94a7807..9d22e9c 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -216,7 +216,7 @@ typedef struct IRQ_src_t { #define IDR_CI 0x40000000 /* critical interrupt */ typedef struct IRQ_dst_t { - uint32_t ctpr; /* CPU current task priority */ + int32_t ctpr; /* CPU current task priority */ IRQ_queue_t raised; IRQ_queue_t servicing; qemu_irq *irqs; @@ -1170,7 +1170,7 @@ static void openpic_save(QEMUFile* f, void *opaque) qemu_put_be32s(f, &opp->nb_cpus); for (i = 0; i < opp->nb_cpus; i++) { - qemu_put_be32s(f, &opp->dst[i].ctpr); + qemu_put_sbe32s(f, &opp->dst[i].ctpr); openpic_save_IRQ_queue(f, &opp->dst[i].raised); openpic_save_IRQ_queue(f, &opp->dst[i].servicing); } @@ -1216,7 +1216,7 @@ static int openpic_load(QEMUFile* f, void *opaque, int version_id) qemu_get_be32s(f, &opp->nb_cpus); for (i = 0; i < opp->nb_cpus; i++) { - qemu_get_be32s(f, &opp->dst[i].ctpr); + qemu_get_sbe32s(f, &opp->dst[i].ctpr); openpic_load_IRQ_queue(f, &opp->dst[i].raised); openpic_load_IRQ_queue(f, &opp->dst[i].servicing); } -- 1.7.9.5