qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoffer Dall <c.dall@virtualopensystems.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Christoffer Dall <c.dall@virtualopensystems.com>,
	kvmarm@lists.cs.columbia.edu
Subject: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit
Date: Sat, 22 Dec 2012 14:03:13 -0500	[thread overview]
Message-ID: <1356202993-55730-1-git-send-email-c.dall@virtualopensystems.com> (raw)

The start bit should only be set to indicate that a function call is
underway, right now.  When done with function, clear it.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Christoffer Dall <c.dall@virtualopensystems.com>
---
 hw/arm_sysctl.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c
index 58eb982..12a62fe 100644
--- a/hw/arm_sysctl.c
+++ b/hw/arm_sysctl.c
@@ -332,6 +332,7 @@ static void arm_sysctl_write(void *opaque, hwaddr offset,
         default:
             s->sys_cfgstat |= 2;        /* error */
         }
+        s->sys_cfgctrl &= ~(1 << 31);
         return;
     case 0xa8: /* SYS_CFGSTAT */
         if (board_id(s) != BOARD_ID_VEXPRESS) {
-- 
1.7.9.5

             reply	other threads:[~2012-12-22 19:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22 19:03 Christoffer Dall [this message]
2012-12-23 11:01 ` [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit Peter Maydell
2012-12-23 16:34   ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356202993-55730-1-git-send-email-c.dall@virtualopensystems.com \
    --to=c.dall@virtualopensystems.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).