* [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit
@ 2012-12-22 19:03 Christoffer Dall
2012-12-23 11:01 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Christoffer Dall @ 2012-12-22 19:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Christoffer Dall, kvmarm
The start bit should only be set to indicate that a function call is
underway, right now. When done with function, clear it.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Christoffer Dall <c.dall@virtualopensystems.com>
---
hw/arm_sysctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c
index 58eb982..12a62fe 100644
--- a/hw/arm_sysctl.c
+++ b/hw/arm_sysctl.c
@@ -332,6 +332,7 @@ static void arm_sysctl_write(void *opaque, hwaddr offset,
default:
s->sys_cfgstat |= 2; /* error */
}
+ s->sys_cfgctrl &= ~(1 << 31);
return;
case 0xa8: /* SYS_CFGSTAT */
if (board_id(s) != BOARD_ID_VEXPRESS) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit
2012-12-22 19:03 [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit Christoffer Dall
@ 2012-12-23 11:01 ` Peter Maydell
2012-12-23 16:34 ` Christoffer Dall
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2012-12-23 11:01 UTC (permalink / raw)
To: Christoffer Dall; +Cc: qemu-devel, kvmarm
On 22 December 2012 19:03, Christoffer Dall
<c.dall@virtualopensystems.com> wrote:
> The start bit should only be set to indicate that a function call is
> underway, right now. When done with function, clear it.
Looks plausible but I'd like a crosscheck that this is how the hardware
really behaves.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit
2012-12-23 11:01 ` Peter Maydell
@ 2012-12-23 16:34 ` Christoffer Dall
0 siblings, 0 replies; 3+ messages in thread
From: Christoffer Dall @ 2012-12-23 16:34 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, kvmarm
On Sun, Dec 23, 2012 at 6:01 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 22 December 2012 19:03, Christoffer Dall
> <c.dall@virtualopensystems.com> wrote:
>> The start bit should only be set to indicate that a function call is
>> underway, right now. When done with function, clear it.
>
> Looks plausible but I'd like a crosscheck that this is how the hardware
> really behaves.
>
sure, on my vexpress box that's certainly the case by experimentation though.
-Christoffer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-23 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-22 19:03 [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit Christoffer Dall
2012-12-23 11:01 ` Peter Maydell
2012-12-23 16:34 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).