From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gleb Natapov" <gleb@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host
Date: Fri, 28 Dec 2012 16:37:34 -0200 [thread overview]
Message-ID: <1356719854-16401-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1356719854-16401-1-git-send-email-ehabkost@redhat.com>
When using -cpu host, we don't need to use the kvm_default_features
variable, as the user is explicitly asking QEMU to enable all feature
supported by the host.
This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to
initialize the kvm_features field, so we get all host KVM features
enabled.
This will also allow use to properly check/enforce KVM features inside
kvm_check_features_against_host() later. For example, we will be able to
make this:
$ qemu-system-x86_64 -cpu ...,+kvm_pv_eoi,enforce
refuse to start if kvm_pv_eoi is not supported by the host (after we fix
kvm_check_features_against_host() to check KVM flags as well).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6e2d32d..76f19f0 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -900,6 +900,8 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
/* Other KVM-specific feature fields: */
x86_cpu_def->svm_features =
kvm_arch_get_supported_cpuid(s, 0x8000000A, 0, R_EDX);
+ x86_cpu_def->kvm_features =
+ kvm_arch_get_supported_cpuid(s, KVM_CPUID_FEATURES, 0, R_EAX);
#endif /* CONFIG_KVM */
}
--
1.7.11.7
next prev parent reply other threads:[~2012-12-28 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 18:37 [Qemu-devel] [PATCH 0/2] Fixes for -cpu host KVM/SVM feature initialization Eduardo Habkost
2012-12-28 18:37 ` [Qemu-devel] [PATCH 1/2] target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features Eduardo Habkost
2013-01-02 14:33 ` Igor Mammedov
2013-01-02 14:39 ` Andreas Färber
2013-01-02 15:19 ` Eduardo Habkost
2012-12-28 18:37 ` Eduardo Habkost [this message]
2013-01-02 14:52 ` [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host Igor Mammedov
2013-01-02 15:29 ` Eduardo Habkost
2013-01-02 20:30 ` Igor Mammedov
2013-01-02 20:52 ` Eduardo Habkost
2013-01-02 14:44 ` [Qemu-devel] [PATCH 0/2] Fixes for -cpu host KVM/SVM feature initialization Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356719854-16401-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).