From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, phrdina@redhat.com,
stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com,
pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 06/11] qmp: add interface query-image
Date: Sat, 29 Dec 2012 16:45:20 +0800 [thread overview]
Message-ID: <1356770725-4804-7-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1356770725-4804-1-git-send-email-xiawenc@linux.vnet.ibm.com>
This mirror function will return all image info including
snapshots. Now Qemu have both query-image and query-block
interfaces, and qemu-img share the code for image info
retrieving with qemu emulator.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
block.c | 16 ++++++++++++++++
qapi-schema.json | 11 +++++++++++
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 9dcecec..0e9f414 100644
--- a/block.c
+++ b/block.c
@@ -2964,6 +2964,22 @@ ImageInfo *bdrv_query_image_info(BlockDriverState *bs, Error **errp)
return info;
}
+ImageInfoList *qmp_query_image(Error **errp)
+{
+ ImageInfoList *head = NULL, **p_next = &head;
+ BlockDriverState *bs;
+
+ QTAILQ_FOREACH(bs, &bdrv_states, list) {
+ ImageInfoList *info = g_malloc0(sizeof(*info));
+ info->value = bdrv_query_image_info(bs, NULL);
+
+ *p_next = info;
+ p_next = &info->next;
+ }
+
+ return head;
+}
+
BlockInfo *bdrv_query_block_info(BlockDriverState *bs)
{
BlockInfo *info = g_malloc0(sizeof(*info));
diff --git a/qapi-schema.json b/qapi-schema.json
index 5dfa052..40f96f3 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -720,6 +720,17 @@
{ 'command': 'query-block', 'returns': ['BlockInfo'] }
##
+# @query-image:
+#
+# Get a list of BlockImage for all virtual block devices.
+#
+# Returns: a list of @BlockImage describing each virtual block device
+#
+# Since: 1.4
+##
+{ 'command': 'query-image', 'returns': ['ImageInfo'] }
+
+##
# @BlockDeviceStats:
#
# Statistics of a virtual block device or a block backing device.
--
1.7.1
next prev parent reply other threads:[~2012-12-29 8:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 8:45 [Qemu-devel] [PATCH 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 01/11] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-01-02 17:58 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-02 23:08 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info() Wenchao Xia
2013-01-03 18:03 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 04/11] qemu-img: move image retrieving function to block layer Wenchao Xia
2013-01-04 17:02 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-04 22:49 ` Eric Blake
2012-12-29 8:45 ` Wenchao Xia [this message]
2013-01-04 23:48 ` [Qemu-devel] [PATCH 06/11] qmp: add interface query-image Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 07/11] block: move bdrv_find_snapshot to block.c Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot Wenchao Xia
2013-01-07 21:21 ` Eric Blake
2013-01-08 2:29 ` Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 11/11] hmp: show snapshot on single block device Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356770725-4804-7-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).