From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, phrdina@redhat.com,
stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com,
pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 07/11] block: move bdrv_find_snapshot to block.c
Date: Sat, 29 Dec 2012 16:45:21 +0800 [thread overview]
Message-ID: <1356770725-4804-8-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1356770725-4804-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
block.c | 23 +++++++++++++++++++++++
include/block/block.h | 2 ++
savevm.c | 22 ----------------------
3 files changed, 25 insertions(+), 22 deletions(-)
diff --git a/block.c b/block.c
index 0e9f414..d7eb213 100644
--- a/block.c
+++ b/block.c
@@ -3349,6 +3349,29 @@ int bdrv_snapshot_load_tmp(BlockDriverState *bs,
return -ENOTSUP;
}
+int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info,
+ const char *name)
+{
+ QEMUSnapshotInfo *sn_tab, *sn;
+ int nb_sns, i, ret;
+
+ ret = -ENOENT;
+ nb_sns = bdrv_snapshot_list(bs, &sn_tab);
+ if (nb_sns < 0) {
+ return ret;
+ }
+ for (i = 0; i < nb_sns; i++) {
+ sn = &sn_tab[i];
+ if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) {
+ *sn_info = *sn;
+ ret = 0;
+ break;
+ }
+ }
+ g_free(sn_tab);
+ return ret;
+}
+
/* backing_file can either be relative, or absolute, or a protocol. If it is
* relative, it must be relative to the chain. So, passing in bs->filename
* from a BDS as backing_file should not be done, as that may be relative to
diff --git a/include/block/block.h b/include/block/block.h
index 3b7c818..41ed5fb 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -340,6 +340,8 @@ int bdrv_snapshot_list(BlockDriverState *bs,
int bdrv_snapshot_load_tmp(BlockDriverState *bs,
const char *snapshot_name);
char *bdrv_snapshot_dump(char *buf, int buf_size, QEMUSnapshotInfo *sn);
+int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info,
+ const char *name);
char *get_human_readable_size(char *buf, int buf_size, int64_t size);
int path_is_absolute(const char *path);
diff --git a/savevm.c b/savevm.c
index 720eea6..6884416 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2074,28 +2074,6 @@ out:
return ret;
}
-static int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info,
- const char *name)
-{
- QEMUSnapshotInfo *sn_tab, *sn;
- int nb_sns, i, ret;
-
- ret = -ENOENT;
- nb_sns = bdrv_snapshot_list(bs, &sn_tab);
- if (nb_sns < 0)
- return ret;
- for(i = 0; i < nb_sns; i++) {
- sn = &sn_tab[i];
- if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) {
- *sn_info = *sn;
- ret = 0;
- break;
- }
- }
- g_free(sn_tab);
- return ret;
-}
-
/*
* Deletes snapshots of a given name in all opened images.
*/
--
1.7.1
next prev parent reply other threads:[~2012-12-29 8:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 8:45 [Qemu-devel] [PATCH 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 01/11] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-01-02 17:58 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-02 23:08 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info() Wenchao Xia
2013-01-03 18:03 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 04/11] qemu-img: move image retrieving function to block layer Wenchao Xia
2013-01-04 17:02 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-04 22:49 ` Eric Blake
2012-12-29 8:45 ` [Qemu-devel] [PATCH 06/11] qmp: add interface query-image Wenchao Xia
2013-01-04 23:48 ` Eric Blake
2012-12-29 8:45 ` Wenchao Xia [this message]
2012-12-29 8:45 ` [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot Wenchao Xia
2013-01-07 21:21 ` Eric Blake
2013-01-08 2:29 ` Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2012-12-29 8:45 ` [Qemu-devel] [PATCH 11/11] hmp: show snapshot on single block device Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356770725-4804-8-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).