qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64
Date: Mon, 31 Dec 2012 10:09:03 -0800	[thread overview]
Message-ID: <1356977344-3679-2-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1356977344-3679-1-git-send-email-rth@twiddle.net>

The interface to normalizeRoundAndPackFloat64 requires that the
high bit be clear.  Perform one shift-right-and-jam if needed.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 fpu/softfloat.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 0cfa6b4..20b05d4 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -1271,11 +1271,18 @@ float64 int64_to_float64( int64 a STATUS_PARAM )
 
 }
 
-float64 uint64_to_float64( uint64 a STATUS_PARAM )
+float64 uint64_to_float64(uint64 a STATUS_PARAM)
 {
-    if ( a == 0 ) return float64_zero;
-    return normalizeRoundAndPackFloat64( 0, 0x43C, a STATUS_VAR );
+    int exp =  0x43C;
 
+    if (a == 0) {
+        return float64_zero;
+    }
+    if ((int64_t)a < 0) {
+        shift64RightJamming(a, 1, &a);
+        exp += 1;
+    }
+    return normalizeRoundAndPackFloat64(0, exp, a STATUS_VAR);
 }
 
 /*----------------------------------------------------------------------------
-- 
1.7.11.7

  reply	other threads:[~2012-12-31 18:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-31 18:09 [Qemu-devel] [PATCH v4 0/2] soft-float-fixes for target-s390x Richard Henderson
2012-12-31 18:09 ` Richard Henderson [this message]
2012-12-31 18:09 ` [Qemu-devel] [PATCH 2/2] softfloat: Implement uint64_to_float128 Richard Henderson
2013-01-04 19:06 ` [Qemu-devel] [PATCH v4 0/2] soft-float-fixes for target-s390x Richard Henderson
2013-01-05 12:15 ` Blue Swirl
  -- strict thread matches above, loose matches on Subject: below --
2012-12-11 17:21 [Qemu-devel] [PATCH v3 " Richard Henderson
2012-12-11 17:21 ` [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 Richard Henderson
2012-12-11 17:34   ` Peter Maydell
2012-12-07 21:52 [Qemu-devel] [PATCH v2 0/2] soft-float fixes for target-s390x Richard Henderson
2012-12-07 21:52 ` [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 Richard Henderson
2012-12-08 10:42   ` Peter Maydell
2012-12-08 14:48   ` Andreas Färber
2012-12-08 16:08     ` Peter Maydell
2012-12-08 17:05       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356977344-3679-2-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).