From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqR10-0002qu-4t for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqR0u-0006E8-3P for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:18:01 -0500 Received: from nodalink.pck.nerim.net ([62.212.105.220]:56255 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqR0t-0006E1-LY for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:17:56 -0500 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Wed, 2 Jan 2013 17:16:19 +0100 Message-Id: <1357143393-29832-17-git-send-email-benoit@irqsave.net> In-Reply-To: <1357143393-29832-1-git-send-email-benoit@irqsave.net> References: <1357143393-29832-1-git-send-email-benoit@irqsave.net> Subject: [Qemu-devel] [RFC V4 16/30] qcow2: Extract qcow2_add_feature and qcow2_remove_feature. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com Signed-off-by: Benoit Canet --- block/qcow2.c | 49 ++++++++++++++++++++++++++++++------------------- block/qcow2.h | 4 ++-- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 499e939..ad399c8 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -236,61 +236,72 @@ static void report_unsupported_feature(BlockDriverState *bs, } /* - * Sets the dirty bit and flushes afterwards if necessary. + * Sets the an incompatible feature bit and flushes afterwards if necessary. * * The incompatible_features bit is only set if the image file header was * updated successfully. Therefore it is not required to check the return * value of this function. */ -int qcow2_mark_dirty(BlockDriverState *bs) +static int qcow2_add_feature(BlockDriverState *bs, + QCow2IncompatibleFeature feature) { BDRVQcowState *s = bs->opaque; uint64_t val; - int ret; + int ret = 0; assert(s->qcow_version >= 3); - if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) { - return 0; /* already dirty */ + if (s->incompatible_features & feature) { + return 0; /* already added */ } - val = cpu_to_be64(s->incompatible_features | QCOW2_INCOMPAT_DIRTY); + val = cpu_to_be64(s->incompatible_features | feature); ret = bdrv_pwrite(bs->file, offsetof(QCowHeader, incompatible_features), &val, sizeof(val)); if (ret < 0) { return ret; } - ret = bdrv_flush(bs->file); - if (ret < 0) { - return ret; - } - /* Only treat image as dirty if the header was updated successfully */ - s->incompatible_features |= QCOW2_INCOMPAT_DIRTY; + /* Only treat image as having the feature if the header was updated + * successfully + */ + s->incompatible_features |= feature; return 0; } +int qcow2_mark_dirty(BlockDriverState *bs) +{ + return qcow2_add_feature(bs, QCOW2_INCOMPAT_DIRTY); +} + /* - * Clears the dirty bit and flushes before if necessary. Only call this - * function when there are no pending requests, it does not guard against - * concurrent requests dirtying the image. + * Clears an incompatible feature bit and flushes before if necessary. + * Only call this function when there are no pending requests, it does not + * guard against concurrent requests adding a feature to the image. */ -static int qcow2_mark_clean(BlockDriverState *bs) +static int qcow2_remove_feature(BlockDriverState *bs, + QCow2IncompatibleFeature feature) { BDRVQcowState *s = bs->opaque; + int ret = 0; - if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) { - int ret = bdrv_flush(bs); + if (s->incompatible_features & feature) { + ret = bdrv_flush(bs); if (ret < 0) { return ret; } - s->incompatible_features &= ~QCOW2_INCOMPAT_DIRTY; + s->incompatible_features &= ~feature; return qcow2_update_header(bs); } return 0; } +static int qcow2_mark_clean(BlockDriverState *bs) +{ + return qcow2_remove_feature(bs, QCOW2_INCOMPAT_DIRTY); +} + static int qcow2_check(BlockDriverState *bs, BdrvCheckResult *result, BdrvCheckMode fix) { diff --git a/block/qcow2.h b/block/qcow2.h index 43586f2..7813c4c 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -159,14 +159,14 @@ enum { }; /* Incompatible feature bits */ -enum { +typedef enum { QCOW2_INCOMPAT_DIRTY_BITNR = 0, QCOW2_INCOMPAT_DIRTY = 1 << QCOW2_INCOMPAT_DIRTY_BITNR, QCOW2_INCOMPAT_DEDUP_BITNR = 1, QCOW2_INCOMPAT_DEDUP = 1 << QCOW2_INCOMPAT_DEDUP_BITNR, QCOW2_INCOMPAT_MASK = QCOW2_INCOMPAT_DIRTY | QCOW2_INCOMPAT_DEDUP, -}; +} QCow2IncompatibleFeature; /* Compatible feature bits */ enum { -- 1.7.10.4