qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: fred.konrad@greensocs.com
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	e.voevodin@samsung.com, mark.burton@greensocs.com, agraf@suse.de,
	stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de,
	fred.konrad@greensocs.com
Subject: [Qemu-devel] [RFC V9 10/12] virtio-blk-s390 : switch to the new API.
Date: Thu,  3 Jan 2013 15:52:22 +0100	[thread overview]
Message-ID: <1357224744-14443-11-git-send-email-fred.konrad@greensocs.com> (raw)
In-Reply-To: <1357224744-14443-1-git-send-email-fred.konrad@greensocs.com>

From: KONRAD Frederic <fred.konrad@greensocs.com>

Here the virtio-blk-s390 is modified for the new API. The device
virtio-blk-s390 extends virtio-s390-device as before. It creates and
connects a virtio-blk during the init. The properties are not modified.

Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
---
 hw/s390-virtio-bus.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index 4e8471b..a2ccdc0 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -165,14 +165,20 @@ static int s390_virtio_net_init(VirtIOS390Device *dev)
 
 static int s390_virtio_blk_init(VirtIOS390Device *dev)
 {
-    VirtIODevice *vdev;
-
-    vdev = virtio_blk_init((DeviceState *)dev, &dev->blk);
-    if (!vdev) {
+    DeviceState *vdev = DEVICE(dev->vdev);
+    virtio_blk_set_conf(vdev, &(dev->blk));
+    qdev_set_parent_bus(vdev, BUS(dev->bus));
+    if (qdev_init(vdev) < 0) {
         return -1;
     }
+    return s390_virtio_device_init(dev, VIRTIO_DEVICE(vdev));
+}
 
-    return s390_virtio_device_init(dev, vdev);
+static void s390_virtio_blk_instance_init(Object *obj)
+{
+    VirtIOS390Device *dev = VIRTIO_S390_DEVICE(obj);
+    dev->vdev = VIRTIO_DEVICE(object_new("virtio-blk"));
+    object_property_add_child(obj, "virtio-backend", OBJECT(dev->vdev), NULL);
 }
 
 static int s390_virtio_serial_init(VirtIOS390Device *dev)
@@ -436,6 +442,7 @@ static TypeInfo s390_virtio_blk = {
     .name          = "virtio-blk-s390",
     .parent        = TYPE_VIRTIO_S390_DEVICE,
     .instance_size = sizeof(VirtIOS390Device),
+    .instance_init = s390_virtio_blk_instance_init,
     .class_init    = s390_virtio_blk_class_init,
 };
 
-- 
1.7.11.7

  parent reply	other threads:[~2013-01-03 14:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 14:52 [Qemu-devel] [RFC V9 00/12] Virtio refactoring fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 01/12] qdev : add a maximum device allowed field for the bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 02/12] virtio-bus : introduce virtio-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 03/12] virtio-pci-bus : introduce virtio-pci-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 04/12] virtio-pci : refactor virtio-pci device fred.konrad
2013-01-04 20:36   ` Blue Swirl
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 05/12] virtio-device : refactor virtio-device fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 06/12] virtio-s390-bus : add virtio-s390-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 07/12] virtio-s390-device : create a virtio-s390-bus during init fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 08/12] virtio-blk : add the virtio-blk device fred.konrad
2013-01-04 20:35   ` Blue Swirl
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 09/12] virtio-blk-pci : switch to new API fred.konrad
2013-01-04 13:57   ` KONRAD Frédéric
2013-01-03 14:52 ` fred.konrad [this message]
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 11/12] virtio-blk : cleanup : use QOM cast fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 12/12] virtio-blk : cleanup : remove qdev field fred.konrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357224744-14443-11-git-send-email-fred.konrad@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=e.voevodin@samsung.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).