From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqtss-00048w-Nd for qemu-devel@nongnu.org; Thu, 03 Jan 2013 18:07:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqtsq-0004PB-16 for qemu-devel@nongnu.org; Thu, 03 Jan 2013 18:07:34 -0500 Date: Thu, 3 Jan 2013 17:07:19 -0600 From: Scott Wood References: <1356142552-13453-1-git-send-email-scottwood@freescale.com> <1356142552-13453-7-git-send-email-scottwood@freescale.com> In-Reply-To: (from agraf@suse.de on Thu Jan 3 12:31:47 2013) Message-ID: <1357254439.22404.14@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/15] openpic: rework critical interrupt support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 01/03/2013 12:31:47 PM, Alexander Graf wrote: >=20 > On 22.12.2012, at 03:15, Scott Wood wrote: >=20 > > Critical interrupts on FSL MPIC are not supposed to pay > > attention to priority, IACK, EOI, etc. On the currently modeled > > version it's not supposed to pay attention to the mask bit either. > > > > Also reorganize to make it easier to implement newer FSL MPIC =20 > models, > > which encode interrupt level information differently and support > > mcheck as well as crit, and to reduce problems for later patches > > in this set. > > > > Still missing is the ability to lower the CINT signal to the core, > > as IACK/EOI is not used. This will come with general =20 > IRQ-source-driven > > lowering in the next patch. > > > > New state is added which is not serialized, but instead is =20 > recomputed > > in openpic_load() by calling the appropriate write_IRQreg function. > > This should have the side effect of causing the IRQ outputs to be > > raised appropriately on load, which was missing. > > > > The serialization format is altered by swapping ivpr and idr (we'd =20 > like > > IDR to be restored before we run the IVPR logic), and moving =20 > interrupts > > to the end (so that other state has been restored by the time we =20 > run the > > IDR/IVPR logic. Serialization for this driver is not yet in a state > > where backwards compatibility is reasonable (assuming it works at =20 > all), > > and the current serialization format was not built for =20 > extensibility. > > > > Signed-off-by: Scott Wood >=20 > Thanks, applied to ppc-next (with adjustments). It looks like one of the adjustments was wrapping an error string -- =20 does QEMU not follow the Linux rule of not wrapping error strings? If =20 not, maybe that should change. QEMU's checkpatch appears to retain the line-length exception, but the =20 set of log functions hasn't been updated (not even to include printf)... -Scott=